diff mbox series

[04/27] ASoC: Intel: cht_bsw_rt5672: check return value

Message ID	20231127152654.28204-5-peter.ujfalusi@linux.intel.com (mailing list archive)
State	Accepted
Commit	65b2df10a1e6264dd199c88623a9e4bbf8849c9b
Headers	show Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="mi9sOO4y" From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> To: lgirdwood@gmail.com, broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, pierre-louis.bossart@linux.intel.com, kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com, yung-chuan.liao@linux.intel.com, chao.song@linux.intel.com Subject: [PATCH 04/27] ASoC: Intel: cht_bsw_rt5672: check return value Date: Mon, 27 Nov 2023 17:26:31 +0200 Message-ID: <20231127152654.28204-5-peter.ujfalusi@linux.intel.com> In-Reply-To: <20231127152654.28204-1-peter.ujfalusi@linux.intel.com> References: <20231127152654.28204-1-peter.ujfalusi@linux.intel.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	ASoC: Intel: Link handling rework and fixes \| expand [00/27] ASoC: Intel: Link handling rework and fixes [01/27] ASoC: Intel: sof_ssp_amp: remove dead code [02/27] ASoC: Intel: sof_maxim_common: add else between 2 if test [03/27] ASoC: Intel: sof_maxim_common: check return value [04/27] ASoC: Intel: cht_bsw_rt5672: check return value [05/27] ASoC: Intel: ssp-common: get codec name function [06/27] ASoC: Intel: board_helpers: support codec link initialization [07/27] ASoC: Intel: sof_cs42l42: use common module for codec link [08/27] ASoC: Intel: sof_nau8825: use common module for codec link [09/27] ASoC: Intel: sof_rt5682: use common module for codec link [10/27] ASoC: Intel: board_helpers: support amp link initialization [11/27] ASoC: Intel: sof_cs42l42: use common module for amp link [12/27] ASoC: Intel: sof_nau8825: use common module for amp link [13/27] ASoC: Intel: sof_rt5682: use common module for amp link [14/27] ASoC: Intel: sof_ssp_amp: use common module for amp link [15/27] ASoC: Intel: sof_ssp_amp: rename function parameter [16/27] ASoC: Intel: board_helpers: support BT offload link initialization [17/27] ASoC: Intel: sof_cs42l42: use common module for BT offload link [18/27] ASoC: Intel: sof_nau8825: use common module for BT offload link [19/27] ASoC: Intel: sof_rt5682: use common module for BT offload link [20/27] ASoC: Intel: sof_ssp_amp: use common module for BT offload link [21/27] ASoC: Intel: sof_ssp_amp: simplify HDMI-In quirks [22/27] ASoC: Intel: board_helpers: support HDMI-In link initialization [23/27] ASoC: Intel: sof_rt5682: use common module for HDMI-In link [24/27] ASoC: Intel: sof_ssp_amp: use common module for HDMI-In link [25/27] ASoC: Intel: board_helpers: support DAI link array generation [26/27] ASoC: Intel: sof_nau8825: use common module for DAI link generation [27/27] ASoC: Intel: sof_rt5682: use common module for DAI link generation

Commit Message

Peter Ujfalusi Nov. 27, 2023, 3:26 p.m. UTC

From: Chao Song <chao.song@linux.intel.com>

Set codec sysclk could fail and return error, add
error check for it.

Signed-off-by: Chao Song <chao.song@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
 sound/soc/intel/boards/cht_bsw_rt5672.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boards/cht_bsw_rt5672.c
index f6da24f3c466..8cf0b33cc02e 100644
--- a/sound/soc/intel/boards/cht_bsw_rt5672.c
+++ b/sound/soc/intel/boards/cht_bsw_rt5672.c
@@ -93,8 +93,12 @@  static int platform_clock_control(struct snd_soc_dapm_widget *w,
 		 * when codec is runtime suspended. Codec needs clock for jack
 		 * detection and button press.
 		 */
-		snd_soc_dai_set_sysclk(codec_dai, RT5670_SCLK_S_RCCLK,
-				       48000 * 512, SND_SOC_CLOCK_IN);
+		ret = snd_soc_dai_set_sysclk(codec_dai, RT5670_SCLK_S_RCCLK,
+					     48000 * 512, SND_SOC_CLOCK_IN);
+		if (ret < 0) {
+			dev_err(card->dev, "failed to set codec sysclk: %d\n", ret);
+			return ret;
+		}
 
 		if (ctx->mclk)
 			clk_disable_unprepare(ctx->mclk);