Message ID | 20231204124736.132185-2-srinivas.kandagatla@linaro.org (mailing list archive) |
---|---|
State | Accepted |
Commit | fb9ad24485087e0f00d84bee7a5914640b2b9024 |
Headers | show |
Series | ASoC: qcom: Limit Digital gains on speaker | expand |
On Mon, Dec 04, 2023 at 12:47:35PM +0000, srinivas.kandagatla@linaro.org wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > Volume can have ranges that start with negative values, ex: -84dB to > +40dB. Apply correct range check in snd_soc_limit_volume before setting > the platform_max. Without this patch, for example setting a 0dB limit on > a volume range of -84dB to +40dB would fail. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Seems to work as intended with the following patch on the X13s: Tested-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Should you add a Fixes and CC-stable tag so we can get this backported (at least to 6.5 for the X13s)? Johan
diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c index 55b009d3c681..2d25748ca706 100644 --- a/sound/soc/soc-ops.c +++ b/sound/soc/soc-ops.c @@ -661,7 +661,7 @@ int snd_soc_limit_volume(struct snd_soc_card *card, kctl = snd_soc_card_get_kcontrol(card, name); if (kctl) { struct soc_mixer_control *mc = (struct soc_mixer_control *)kctl->private_value; - if (max <= mc->max) { + if (max <= mc->max - mc->min) { mc->platform_max = max; ret = 0; }