| Message ID | 20231218203659.32948-2-aabishmalik3337@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [6.6.7,1/1] ALSA: hda/realtek: mute led fix for HP Pavilion 14 ec1xxx series | expand |
On Mon, 18 Dec 2023 21:37:00 +0100, opticXC wrote: > > The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec. > It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute led. > > > Signed-off-by: opticXC <aabishmalik3337@gmail.com> > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index e45d4c405..416cda983 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > + SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED), The entry has a coding style problem; it uses 4 spaces instead of a hard tab stop. Please use a hard tab stop and resubmit. thanks, Takashi
On Fri, Dec 29, 2023 at 02:24:14PM +0100, Takashi Iwai wrote: > On Mon, 18 Dec 2023 21:37:00 +0100, > opticXC wrote: > > > > The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec. > > It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute led. > > > > > > Signed-off-by: opticXC <aabishmalik3337@gmail.com> > > --- > > sound/pci/hda/patch_realtek.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index e45d4c405..416cda983 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > > SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > > + SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED), > > The entry has a coding style problem; it uses 4 spaces instead of a > hard tab stop. > > Please use a hard tab stop and resubmit. Hi Takashi, I also think his Signed-off-by line is a no-go unless he can prove opticXC is a legal name. Thanks, Geraldo Nascimento > > > thanks, > > Takashi >
On Sat, 30 Dec 2023 02:16:06 +0100, Geraldo Nascimento wrote: > > On Fri, Dec 29, 2023 at 02:24:14PM +0100, Takashi Iwai wrote: > > On Mon, 18 Dec 2023 21:37:00 +0100, > > opticXC wrote: > > > > > > The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec. > > > It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute led. > > > > > > > > > Signed-off-by: opticXC <aabishmalik3337@gmail.com> > > > --- > > > sound/pci/hda/patch_realtek.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > > index e45d4c405..416cda983 100644 > > > --- a/sound/pci/hda/patch_realtek.c > > > +++ b/sound/pci/hda/patch_realtek.c > > > @@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > > SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > > > SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > > > SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > > > + SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED), > > > > The entry has a coding style problem; it uses 4 spaces instead of a > > hard tab stop. > > > > Please use a hard tab stop and resubmit. > > Hi Takashi, I also think his Signed-off-by line is a no-go unless he can > prove opticXC is a legal name. Right. Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index e45d4c405..416cda983 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), + SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), SND_PCI_QUIRK(0x103c, 0x8a25, "HP Victus 16-d1xxx (MB 8A25)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT), SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec. It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute led. Signed-off-by: opticXC <aabishmalik3337@gmail.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)