| Message ID | 20240131113407.34698-3-josemonsantorelvas@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2468e8922d2f6da81a6192b73023eff67e3fefdd |
| Headers | show |
| Series | [V2] Apply headset jack quirk for non-bass alc287 thinkpads | expand |
On Wed, 31 Jan 2024 12:34:09 +0100, José Relvas wrote: > > There currently exists two thinkpad headset jack fixups: > ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK > ALC285_FIXUP_THINKPAD_HEADSET_JACK > > The latter is applied to alc285 and alc287 thinkpads which contain bass speakers. > However, the former was only being applied to alc285 thinkpads, > leaving non-bass alc287 thinkpads with no headset button controls. > This patch fixes that by adding ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK > to the alc287 chains, allowing the detection of headset buttons. > > Signed-off-by: José Relvas <josemonsantorelvas@gmail.com> Applied now. Thanks. Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index dde21bebed17..4c78cd07e80b 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9419,7 +9419,7 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = cs35l41_fixup_i2c_two, .chained = true, - .chain_id = ALC269_FIXUP_THINKPAD_ACPI, + .chain_id = ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK, }, [ALC287_FIXUP_TAS2781_I2C] = { .type = HDA_FIXUP_FUNC, @@ -9446,6 +9446,8 @@ static const struct hda_fixup alc269_fixups[] = { [ALC287_FIXUP_THINKPAD_I2S_SPK] = { .type = HDA_FIXUP_FUNC, .v.func = alc287_fixup_bind_dacs, + .chained = true, + .chain_id = ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK, }, [ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD] = { .type = HDA_FIXUP_FUNC,
There currently exists two thinkpad headset jack fixups: ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK ALC285_FIXUP_THINKPAD_HEADSET_JACK The latter is applied to alc285 and alc287 thinkpads which contain bass speakers. However, the former was only being applied to alc285 thinkpads, leaving non-bass alc287 thinkpads with no headset button controls. This patch fixes that by adding ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK to the alc287 chains, allowing the detection of headset buttons. Signed-off-by: José Relvas <josemonsantorelvas@gmail.com> --- sound/pci/hda/patch_realtek.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)