| Message ID | 20240202140619.1068560-1-ckeepax@opensource.cirrus.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cd2a2388614fcf2b9b626332c0da53a2c6cbf2ee |
| Headers | show |
| Series | [1/3] ASoC: cs42l43: Add clear of stashed pointer on component remove | expand |
On Fri, 02 Feb 2024 14:06:17 +0000, Charles Keepax wrote: > If the component is removed the stashed component pointer in the > CODECs private struct should also be cleared to prevent use of a stale > pointer. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/3] ASoC: cs42l43: Add clear of stashed pointer on component remove commit: cd2a2388614fcf2b9b626332c0da53a2c6cbf2ee [2/3] ASoC: cs42l43: Sync the hp ilimit works when removing the component commit: 7fa1a01ba6cb64bc24e7ba0dbee589f3f09f3cf7 [3/3] ASoC: cs42l43: Shut down jack detection on component remove commit: 3ef9f445ddb1e061ce497f54ca75bbaec52a3a46 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c index 2c402086924d..9e1deb3242cb 100644 --- a/sound/soc/codecs/cs42l43.c +++ b/sound/soc/codecs/cs42l43.c @@ -2111,10 +2111,18 @@ static int cs42l43_component_probe(struct snd_soc_component *component) return 0; } +static void cs42l43_component_remove(struct snd_soc_component *component) +{ + struct cs42l43_codec *priv = snd_soc_component_get_drvdata(component); + + priv->component = NULL; +} + static const struct snd_soc_component_driver cs42l43_component_drv = { .name = "cs42l43-codec", .probe = cs42l43_component_probe, + .remove = cs42l43_component_remove, .set_sysclk = cs42l43_set_sysclk, .set_jack = cs42l43_set_jack,
If the component is removed the stashed component pointer in the CODECs private struct should also be cleared to prevent use of a stale pointer. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- sound/soc/codecs/cs42l43.c | 8 ++++++++ 1 file changed, 8 insertions(+)