From patchwork Thu Mar 28 14:51:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13608694 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CCE012FF80; Thu, 28 Mar 2024 14:52:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.7.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711637544; cv=fail; b=YSpoarP8mK4w8j9upVD6qJaM1uuv7MqYEdLCld91GtXWy2a8syOuOyqqVCXXXY1gu1Ku8QTy4842ssqpv4YvM3JDBXo1flSLsV+jhS+Pey475sG3+GxGwUfyU8xoYhwyq+Wp0kr+HWShrOTZpXnu1PTktJRWVkZfSm1Er4xfMHc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711637544; c=relaxed/simple; bh=/PdQ4YvjdSlrCyI1P1udeJhqTS+Sl1PFyZdORP2g+WY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=GaRBTVY1N5uheahuS5c4/ZNMHlkd4B/n8gA2Z9ghY1PyYzYY0MR91101wTk38K9Ci9whml4SQmdPvQEEGR0AyHyeR7GBZm3eL6dK+11IOgK58dEMwQMH2HrIXvxOdRfgys6G7I1uWfq6BkCBX1kTpaTan10ucrbuHJDn6v+z6rY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=R9g71rtI; arc=fail smtp.client-ip=40.107.7.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="R9g71rtI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ncrEBsrRuNBvsFNU8QadeIKnpd0l8sDK9FlILLVtppNyGwwvBJw+2N9oTktXUGMI0WtCrpLgcAbgBfTr5pMzuNzwdGmjUH07dafAmhQbsbFUEHkDp8tnKnjVxkcsK7rQI65ZqqRnOoESQPgl9qNumFErW+VnG6fuzCO2YNIVfLMwysCf4wY+ly3bu34p8UEOMxDXGEctLSHqSZdD/QLwPGM9rYiIcmf+NXWTqzEsZkIQKo2MKYjRNB6KkEMWLfgPMG4AIEcS7E9dlFneFSKnCYbLA0bAFjucZuDoJQNCQxrUhi7ogzzYbxpazROGkQqrwkE41kwlwfOMgsZgKZdoAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hN14lHU+0CsdUJqY1Rzb8KcbmwECVonpQGw+AiHtz6s=; b=l1ajqAz1dkb/SY1IiwAj1Dz/xapf0I6rGpyCvt/3DyoLVm08v+tfD4XCtEQnLDzHRnUYs2dLEJavRUyRhEPHfIkh2kzoL1uMBRqAF4CBv7twtm4Bw6Sr0WnH6CVo9NBRsSfpduRnS2r5MVchQh7zK/Prq7EEGzBDn6f5R/6366mIDy1y3mh6ZPKejP/z0zjnvCcxs0csmhhK2lurF6iTYHZa8HgZP7TeLc8CZrBCwnvzukD+qGBgXULwuXeTaTeaX7TLHj3ZHhl6yViMsKeXaPp/fzekSLKqLUJB3dBBOKEfUQ64WFSJu8oM8MyN7sOSgtAC5yHWX3Vnvyt4L2yPuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hN14lHU+0CsdUJqY1Rzb8KcbmwECVonpQGw+AiHtz6s=; b=R9g71rtIjesXnd1xsQXX5citau4LPSoyaE4EcJ+7jrGN00s1hSHJpgJE8F+zzPUuk37cHTguLAr4fsA6Ro16YWqJvJczjM7PgbAYuAdhmhcUsH20PusLAubqgoZEn25aivOO0I85LUM9Az4vXEy1x0iV9OHF58N7iJ8kseHzrUM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PAXPR04MB8880.eurprd04.prod.outlook.com (2603:10a6:102:20f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Thu, 28 Mar 2024 14:52:18 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.028; Thu, 28 Mar 2024 14:52:17 +0000 From: Frank Li Date: Thu, 28 Mar 2024 10:51:36 -0400 Subject: [PATCH v8 4/5] arm64: dts: imx8: fix audio lpcg index Message-Id: <20240328-asrc_8qxp-v8-4-801cd6bb5be2@nxp.com> References: <20240328-asrc_8qxp-v8-0-801cd6bb5be2@nxp.com> In-Reply-To: <20240328-asrc_8qxp-v8-0-801cd6bb5be2@nxp.com> To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shengjiu Wang Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1711637518; l=2684; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=/PdQ4YvjdSlrCyI1P1udeJhqTS+Sl1PFyZdORP2g+WY=; b=9fgcL/tK4jBcmXzGRgfA7M0USXD8mOkQAKg27MKhroZzhkldxI1lzUNQVD/SsY6nsgNoUxnZM Nsb8WyylcUyBvzG1WG6dOmiFphJzENDeZb35/QE59a5KWD5HS/IenEA X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR11CA0087.namprd11.prod.outlook.com (2603:10b6:a03:f4::28) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PAXPR04MB8880:EE_ X-MS-Office365-Filtering-Correlation-Id: 251bb4fb-b304-4fb2-7702-08dc4f36a9e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8IwifRQVqgYxjeIR20pySEySUtchegjatFNw1SiitnEf/jWEN9qNluR3pxTRvSnCeS2L6TN+oU98vq9NgJK3BCrxen+6FxFrMBtQZXmfFGmc4CIoLSd5ZtNZZlivBbS0av+CmcUhyR2SD1iB/HEkrILPw5pK1vBIWXi7IzgByWvt59uE3PFz0EBvHdp9S27qLP6sZeryxv9KkrGzTB3tO7KhPHw9tphnk+SCzR5WdImnVU6wEwS8GpWyAJPn9wE8+CwgDATU/O9WXgYLTLLm3ahsgjEA7WBp4fs6Oy6RBoMFNQlYZrK5/WJy0iYryVB4FKxVOc8yNXL4kw3Ls/uCL4RdIvQX8TM0M8Rz5giHnwek1xFaJywDXQ08VasLZ+8M3q9/EBGEO0cxYBfAL1ExnukbtTbJr8MJb3QRiEGnE7eO5YpV7Bkqd27ifDEe2Kth2TNNEYtOswK5M0SfhYa7ywOQkE32JttjYJWxoArlKsA5j5GNuFFSjXon+fT2PGea7vzqSMhkFHz79vCkXU0mqhG2HHuGOdp6lPQwmF/DM0Mif5cJ2wKZ8m5GOiteV8dRek36E2KY2VTXETr/Cvi8450zH7zcmgPWqE5H55Hm7NL7DCkWDi0cs8aJ0Y5CdH0mbgqpAGVS5o1gA7oMXDgoC4LsLMOcfMUeoUOgRq/NEomd9P2NqsoG9yp6+EI6yRSwWw4MOjAXUMtNg5YFBvshRA267NEfO4JbNyek7odClIQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005)(52116005)(7416005)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?AUm3sJoyutw9DkBO2gJ8oWKaUnWZ?= =?utf-8?q?kbut2FbpFsWeX3H+y5vqNdlQ/xqepF+l9393MbAGdLrLf12Ha0W+YPr0+oX62CqEH?= =?utf-8?q?OS3Vv86UMp3mW4Oamp8QMej/ZUWOeFt/o5ai3zWWIzHrHXnr5JzVOyt+oQ3vnRwb0?= =?utf-8?q?KBzAH38goSDpynH5KsT9cKeqbbDLhjK8aAftz8kQmtRXUY/Q5dSyuGbLAsj7foaKA?= =?utf-8?q?lq+JG2Q/lw/wJKjOJ3LNUzUXERnuz7GWfaQVLu9DM/oU69MmHB643e4T4Eu/+3ezV?= =?utf-8?q?USfbQ9K5Dwc4WJrbutmh1jc8zUriCNNrIpuhnfKPAtXlD/N696d7wg0ESpAy4NuNW?= =?utf-8?q?Lq+KCh3v5mKwBtirz8tN7D3tjn9PNQQEV2oLbhjcW1tb4MCSJ+ZTTgc/RmpKpjaa4?= =?utf-8?q?uDOszuf6LuE/XDXCVAOSqgZMirUpi6kv8JkcptJSXCw5YNBnW7LZeIDHA/f5eGKU2?= =?utf-8?q?PzVbADgoBKjWn2sVEudPX0Uj55xmC7xQT3O9hkgonbAxPzhv4iX98dBqju9/Pzsv1?= =?utf-8?q?SvEZ5R7ZW0TYzf9UZqzyviADDUAGKk7j3PvH0ftDeeGQ6xsIrXzvSXLFB9b/e8vA7?= =?utf-8?q?JMGBrqQaOZ5HIL4bJEjkWPI4s51tdbD0Wh8/3q2f9iF+7MpNBDT3A9FCOItM+7bsF?= =?utf-8?q?0+i0vyXuYAzpNaGjOkUYfezcgQxh96AOz1pWr3Isfvn3WlGWExp3T1o9YiCMNyvey?= =?utf-8?q?HDYbL1GJcbaszE+0ScaVXBGRGx9lOyWCyJxVc55gAi4vE/Eja7TM2mhcuFe7zSwf7?= =?utf-8?q?Zni1yaKS5Yf8xr52nEmMuL1AX/s0rrj7WWepN+m+gchobSyU7Xb8tC5v2uEuvyPV5?= =?utf-8?q?ZGwUsBSH3ank0oiBlZmdrUJ3ghNEpvDj7xfDd3OHElQIJN9m4q5fHeVKvtDnyez5l?= =?utf-8?q?ty0C+NkjGfD5uV7knS0PwkGF0vf3yRtUBnMxnZAeRbHm8PRb3av4nHzB7JXnr3qZ2?= =?utf-8?q?9wXfTKLSwnulatnrbAGP1my7A3Taiz+2KFtQmLhbpWqgwen6bNBcBoylN/M9wxi2K?= =?utf-8?q?sGc2HIGmNiNk/czfElG6Y5Aurcch5+53Ita/U8Ur6LAIxGhMcbAy8nP+BCmCNS5un?= =?utf-8?q?942PZdQUzhtBs0fcjKGJm8CM4MjNGK6mv/EivgRT3bHo1rpFfk7Tlmn8fn1OKszzB?= =?utf-8?q?8lpTI9GKrcOenE1tXIEMX3WjlcYgM9pIF2wAGAjeuj4b6ED4JparevSR2wmYGKk+7?= =?utf-8?q?bROYx9t1A0k5o/2ax4ljfuM6DmBiVSTgroPn+mPzJ3pABC7WsRSaOUIiOAfT/r/8/?= =?utf-8?q?WR8YWl5xigJEaJxJlxlQiRNtZoSocE4+iOYa8uIqufdsFucpSZuMKAeCyEhIRYFG0?= =?utf-8?q?mySs4dQemnM1wpIx+lVEt+UKF+K12zQFuCV/AWRgDHkYSALgHKe3KsNpfUibm29EH?= =?utf-8?q?lwW75x6feX+v97yjN+ZLMWClRUm1kkaTTEo9d+zslkaM9r+uhhN/4uI/Vzd82jDuw?= =?utf-8?q?pyg11IIp7XLw7ajULp6JrRCQzch4S/CUyPnVxANUzoRxkmf+dl2AWqvVB0h9xmZDx?= =?utf-8?q?6gGPN7vVQZuF?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 251bb4fb-b304-4fb2-7702-08dc4f36a9e1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 14:52:17.7812 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AfILx6AytqDQNFORDVCv7tkfga1OO/2J85OiiSbZ2t27e8Ji/MZFyF4K6xLkX48plujgJsum5JSG11WLrxwnRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8880 lpcg cell0 should be clock's 'indices' instead of 'index'. imx_lpcg_of_clk_src_get(struct of_phandle_args *clkspec, void *data) { struct clk_hw_onecell_data *hw_data = data; unsigned int idx = clkspec->args[0] / 4; .... } <@sai0_lpcg 1> will be the same as <@sai_lpcg 0>. Replace 0 with IMX_LPCG_CLK_0 and replace 1 with IMX_LPCG_CLK_4. It can work at iMX8QXP because IMX_LPCG_CLK_4 is ipg clock, which already enabled. But for iMX8QM IMX_LPCG_CLK_4 is mclk, which trigger issue. Fixes: 0a9279e9ae88 ("arm64: dts: imx8qxp: Add audio SAI nodes") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi index 07afeb78ed564..d8bbe53320bce 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi @@ -123,9 +123,9 @@ sai0: sai@59040000 { compatible = "fsl,imx8qm-sai"; reg = <0x59040000 0x10000>; interrupts = ; - clocks = <&sai0_lpcg 1>, + clocks = <&sai0_lpcg IMX_LPCG_CLK_4>, <&clk_dummy>, - <&sai0_lpcg 0>, + <&sai0_lpcg IMX_LPCG_CLK_0>, <&clk_dummy>, <&clk_dummy>; clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3"; @@ -139,9 +139,9 @@ sai1: sai@59050000 { compatible = "fsl,imx8qm-sai"; reg = <0x59050000 0x10000>; interrupts = ; - clocks = <&sai1_lpcg 1>, + clocks = <&sai1_lpcg IMX_LPCG_CLK_4>, <&clk_dummy>, - <&sai1_lpcg 0>, + <&sai1_lpcg IMX_LPCG_CLK_0>, <&clk_dummy>, <&clk_dummy>; clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3"; @@ -155,9 +155,9 @@ sai2: sai@59060000 { compatible = "fsl,imx8qm-sai"; reg = <0x59060000 0x10000>; interrupts = ; - clocks = <&sai2_lpcg 1>, + clocks = <&sai2_lpcg IMX_LPCG_CLK_4>, <&clk_dummy>, - <&sai2_lpcg 0>, + <&sai2_lpcg IMX_LPCG_CLK_0>, <&clk_dummy>, <&clk_dummy>; clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3"; @@ -171,9 +171,9 @@ sai3: sai@59070000 { compatible = "fsl,imx8qm-sai"; reg = <0x59070000 0x10000>; interrupts = ; - clocks = <&sai3_lpcg 1>, + clocks = <&sai3_lpcg IMX_LPCG_CLK_4>, <&clk_dummy>, - <&sai3_lpcg 0>, + <&sai3_lpcg IMX_LPCG_CLK_0>, <&clk_dummy>, <&clk_dummy>; clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";