| Message ID | 20240405104306.551036-1-spujar@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2e93a29b48a017c777d4fcbfcc51aba4e6a90d38 |
| Headers | show |
| Series | [RESEND,v2] ASoC: tegra: Fix DSPK 16-bit playback | expand |
On Fri Apr 5, 2024 at 12:43 PM CEST, Sameer Pujar wrote: > DSPK configuration is wrong for 16-bit playback and this happens because > the client config is always fixed at 24-bit in hw_params(). Fix this by > updating the client config to 16-bit for the respective playback. > > Fixes: 327ef6470266 ("ASoC: tegra: Add Tegra186 based DSPK driver") > Cc: stable@vger.kernel.org > Signed-off-by: Sameer Pujar <spujar@nvidia.com> > --- > changes in v2: > * moved common setting to S32_LE switch case. > > sound/soc/tegra/tegra186_dspk.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
On Fri, 05 Apr 2024 10:43:06 +0000, Sameer Pujar wrote: > DSPK configuration is wrong for 16-bit playback and this happens because > the client config is always fixed at 24-bit in hw_params(). Fix this by > updating the client config to 16-bit for the respective playback. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: tegra: Fix DSPK 16-bit playback commit: 2e93a29b48a017c777d4fcbfcc51aba4e6a90d38 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/tegra/tegra186_dspk.c b/sound/soc/tegra/tegra186_dspk.c index aa37c4ab0adb..21cd41fec7a9 100644 --- a/sound/soc/tegra/tegra186_dspk.c +++ b/sound/soc/tegra/tegra186_dspk.c @@ -1,8 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only +// SPDX-FileCopyrightText: Copyright (c) 2020-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. // // tegra186_dspk.c - Tegra186 DSPK driver -// -// Copyright (c) 2020 NVIDIA CORPORATION. All rights reserved. #include <linux/clk.h> #include <linux/device.h> @@ -241,14 +240,14 @@ static int tegra186_dspk_hw_params(struct snd_pcm_substream *substream, return -EINVAL; } - cif_conf.client_bits = TEGRA_ACIF_BITS_24; - switch (params_format(params)) { case SNDRV_PCM_FORMAT_S16_LE: cif_conf.audio_bits = TEGRA_ACIF_BITS_16; + cif_conf.client_bits = TEGRA_ACIF_BITS_16; break; case SNDRV_PCM_FORMAT_S32_LE: cif_conf.audio_bits = TEGRA_ACIF_BITS_32; + cif_conf.client_bits = TEGRA_ACIF_BITS_24; break; default: dev_err(dev, "unsupported format!\n");
DSPK configuration is wrong for 16-bit playback and this happens because the client config is always fixed at 24-bit in hw_params(). Fix this by updating the client config to 16-bit for the respective playback. Fixes: 327ef6470266 ("ASoC: tegra: Add Tegra186 based DSPK driver") Cc: stable@vger.kernel.org Signed-off-by: Sameer Pujar <spujar@nvidia.com> --- changes in v2: * moved common setting to S32_LE switch case. sound/soc/tegra/tegra186_dspk.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)