diff mbox series

ALSA: hda/realtek: Remove Framework Laptop 16 from quirks

Message ID 20240605-alsa-hda-realtek-remove-framework-laptop-16-from-quirks-v1-1-11d47fe8ec4d@howett.net (mailing list archive)
State New, archived
Headers show
Series ALSA: hda/realtek: Remove Framework Laptop 16 from quirks | expand

Commit Message

Dustin L. Howett June 5, 2024, 5:01 p.m. UTC 
The Framework Laptop 16 does not have a combination headphone/headset
3.5mm jack; however, applying the pincfg from the Laptop 13 (nid=0x19)
erroneously informs hda that the node is present.

Fixes: 8804fa04a492 ("ALSA: hda/realtek: Add Framework laptop 16 to quirks")
Signed-off-by: Dustin L. Howett <dustin@howett.net>
---
 sound/pci/hda/patch_realtek.c | 1 -
 1 file changed, 1 deletion(-)


---
base-commit: 7b44d5381e541de3da3cee2e948456b250f41f25
change-id: 20240605-alsa-hda-realtek-remove-framework-laptop-16-from-quirks-dc60267cb5e7

Best regards,

Comments

Dustin L. Howett June 5, 2024, 5:11 p.m. UTC | #1 
On Wed, Jun 5, 2024 at 12:03 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> On 6/5/2024 12:01, Dustin L. Howett wrote:
> > The Framework Laptop 16 does not have a combination headphone/headset
> > 3.5mm jack; however, applying the pincfg from the Laptop 13 (nid=0x19)
> > erroneously informs hda that the node is present.
>
> But doesn't the audio card work this way?

I don't believe so - the audio expansion card enumerates as a USB
device that is picked up by snd-usb-audio.
A headset microphone connected to the audio expansion card seems to
continue working properly even with this pinctrl change (synthetically
tested on my Framework Laptop 13, mind you -- it is not a perfect test
:)).

d
Kieran Levin June 5, 2024, 11:15 p.m. UTC | #2 
The audio expansion card has a full usb to headphone jack codec. So does
not interact with HDA at all.

On Thu, Jun 6, 2024, 1:11 AM Dustin Howett <dustin@howett.net> wrote:

> On Wed, Jun 5, 2024 at 12:03 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
> >
> > On 6/5/2024 12:01, Dustin L. Howett wrote:
> > > The Framework Laptop 16 does not have a combination headphone/headset
> > > 3.5mm jack; however, applying the pincfg from the Laptop 13 (nid=0x19)
> > > erroneously informs hda that the node is present.
> >
> > But doesn't the audio card work this way?
>
> I don't believe so - the audio expansion card enumerates as a USB
> device that is picked up by snd-usb-audio.
> A headset microphone connected to the audio expansion card seems to
> continue working properly even with this pinctrl change (synthetically
> tested on my Framework Laptop 13, mind you -- it is not a perfect test
> :)).
>
> d
>
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e3c0b9d5552d..127f5933abd7 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10605,7 +10605,6 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10),
 	SND_PCI_QUIRK(0x8086, 0x3038, "Intel NUC 13", ALC295_FIXUP_CHROME_BOOK),
 	SND_PCI_QUIRK(0xf111, 0x0001, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
-	SND_PCI_QUIRK(0xf111, 0x0005, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0xf111, 0x0006, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
 
 #if 0