diff mbox series

ASoC: SOF: imx8m: Fix DSP control regmap retrieval

Message ID 20240715151653.114751-1-daniel.baluta@oss.nxp.com (mailing list archive)
State Accepted
Commit 2634f745eac25a33f032df32cf98fca8538a534a
Headers show
Series ASoC: SOF: imx8m: Fix DSP control regmap retrieval | expand

Commit Message

Daniel Baluta (OSS) July 15, 2024, 3:16 p.m. UTC
From: Daniel Baluta <daniel.baluta@nxp.com>

According to Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
fsl,dsp-ctrl is a phandle to syscon block so we need to use correct
function to retrieve it.

Currently there is no SOF DSP DTS merged into mainline so there is no
need to support the old way of retrieving the dsp control node.

Fixes: 9ba23717b292 ("ASoC: SOF: imx8m: Implement DSP start")
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
 sound/soc/sof/imx/imx8m.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown July 16, 2024, 1:26 p.m. UTC | #1
On Mon, 15 Jul 2024 18:16:53 +0300, Daniel Baluta (OSS) wrote:
> According to Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> fsl,dsp-ctrl is a phandle to syscon block so we need to use correct
> function to retrieve it.
> 
> Currently there is no SOF DSP DTS merged into mainline so there is no
> need to support the old way of retrieving the dsp control node.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: imx8m: Fix DSP control regmap retrieval
      commit: 2634f745eac25a33f032df32cf98fca8538a534a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Iuliana Prodan July 16, 2024, 1:36 p.m. UTC | #2
On 7/15/2024 6:16 PM, Daniel Baluta (OSS) wrote:
> From: Daniel Baluta <daniel.baluta@nxp.com>
>
> According to Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> fsl,dsp-ctrl is a phandle to syscon block so we need to use correct
> function to retrieve it.
>
> Currently there is no SOF DSP DTS merged into mainline so there is no
> need to support the old way of retrieving the dsp control node.
>
> Fixes: 9ba23717b292 ("ASoC: SOF: imx8m: Implement DSP start")
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>


Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>


Thanks,
Iulia
> ---
>   sound/soc/sof/imx/imx8m.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c
> index 1c7019c3cbd38..cdd1e79ef9f6a 100644
> --- a/sound/soc/sof/imx/imx8m.c
> +++ b/sound/soc/sof/imx/imx8m.c
> @@ -234,7 +234,7 @@ static int imx8m_probe(struct snd_sof_dev *sdev)
>   	/* set default mailbox offset for FW ready message */
>   	sdev->dsp_box.offset = MBOX_OFFSET;
>   
> -	priv->regmap = syscon_regmap_lookup_by_compatible("fsl,dsp-ctrl");
> +	priv->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,dsp-ctrl");
>   	if (IS_ERR(priv->regmap)) {
>   		dev_err(sdev->dev, "cannot find dsp-ctrl registers");
>   		ret = PTR_ERR(priv->regmap);
diff mbox series

Patch

diff --git a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c
index 1c7019c3cbd38..cdd1e79ef9f6a 100644
--- a/sound/soc/sof/imx/imx8m.c
+++ b/sound/soc/sof/imx/imx8m.c
@@ -234,7 +234,7 @@  static int imx8m_probe(struct snd_sof_dev *sdev)
 	/* set default mailbox offset for FW ready message */
 	sdev->dsp_box.offset = MBOX_OFFSET;
 
-	priv->regmap = syscon_regmap_lookup_by_compatible("fsl,dsp-ctrl");
+	priv->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,dsp-ctrl");
 	if (IS_ERR(priv->regmap)) {
 		dev_err(sdev->dev, "cannot find dsp-ctrl registers");
 		ret = PTR_ERR(priv->regmap);