| Message ID | 20240911123751.2078-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f6e2e7397d00192bda11166d5fb3e2e67a8cf92e |
| Headers | show |
| Series | ASoC: mediatek: Remove redundant error message | expand |
Il 11/09/24 14:37, Tang Bin ha scritto: > In the function mt7986_afe_pcm_dev_probe, when get irq > failed, the function platform_get_irq() logs an error > message, so remove redundant one here. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Please clarify the commit titie, like ASoC: mediatek: mt7986-afe-pcm: Remove redundant error message After which, Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff --git a/sound/soc/mediatek/mt7986/mt7986-afe-pcm.c b/sound/soc/mediatek/mt7986/mt7986-afe-pcm.c index d400bea0e..7db090414 100644 --- a/sound/soc/mediatek/mt7986/mt7986-afe-pcm.c +++ b/sound/soc/mediatek/mt7986/mt7986-afe-pcm.c @@ -529,10 +529,9 @@ static int mt7986_afe_pcm_dev_probe(struct platform_device *pdev) /* request irq */ irq_id = platform_get_irq(pdev, 0); - if (irq_id < 0) { - ret = irq_id; - return dev_err_probe(dev, ret, "No irq found\n"); - } + if (irq_id < 0) + return irq_id; + ret = devm_request_irq(dev, irq_id, mt7986_afe_irq_handler, IRQF_TRIGGER_NONE, "asys-isr", (void *)afe); if (ret)
In the function mt7986_afe_pcm_dev_probe, when get irq failed, the function platform_get_irq() logs an error message, so remove redundant one here. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- sound/soc/mediatek/mt7986/mt7986-afe-pcm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)