| Message ID | 20241002025659.723544-1-hui.wang@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 47d7d3fd72afc7dcd548806291793ee6f3848215 |
| Headers | show |
| Series | ASoC: imx-card: Set card.owner to avoid a warning calltrace if SND=m | expand |
On Wed, 02 Oct 2024 10:56:59 +0800, Hui Wang wrote: > In most Linux distribution kernels, the SND is set to m, in such a > case, when booting the kernel on i.MX8MP EVK board, there is a > warning calltrace like below: > Call trace: > snd_card_init+0x484/0x4cc [snd] > snd_card_new+0x70/0xa8 [snd] > snd_soc_bind_card+0x310/0xbd0 [snd_soc_core] > snd_soc_register_card+0xf0/0x108 [snd_soc_core] > devm_snd_soc_register_card+0x4c/0xa4 [snd_soc_core] > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: imx-card: Set card.owner to avoid a warning calltrace if SND=m commit: 47d7d3fd72afc7dcd548806291793ee6f3848215 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/fsl/imx-card.c b/sound/soc/fsl/imx-card.c index 98b37dd2b901..a7215bad6484 100644 --- a/sound/soc/fsl/imx-card.c +++ b/sound/soc/fsl/imx-card.c @@ -710,6 +710,7 @@ static int imx_card_probe(struct platform_device *pdev) data->plat_data = plat_data; data->card.dev = &pdev->dev; + data->card.owner = THIS_MODULE; dev_set_drvdata(&pdev->dev, &data->card); snd_soc_card_set_drvdata(&data->card, data);
In most Linux distribution kernels, the SND is set to m, in such a case, when booting the kernel on i.MX8MP EVK board, there is a warning calltrace like below: Call trace: snd_card_init+0x484/0x4cc [snd] snd_card_new+0x70/0xa8 [snd] snd_soc_bind_card+0x310/0xbd0 [snd_soc_core] snd_soc_register_card+0xf0/0x108 [snd_soc_core] devm_snd_soc_register_card+0x4c/0xa4 [snd_soc_core] That is because the card.owner is not set, a warning calltrace is raised in the snd_card_init() due to it. Fixes: aa736700f42f ("ASoC: imx-card: Add imx-card machine driver") Signed-off-by: Hui Wang <hui.wang@canonical.com> --- sound/soc/fsl/imx-card.c | 1 + 1 file changed, 1 insertion(+)