| Message ID | 20241009065345.6669-1-zhujun2@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: ice1712: Remove redundant code in stac9460_dac_vol_put | expand |
On Wed, 09 Oct 2024 08:53:45 +0200, Zhu Jun wrote: > > The variable 'ovol' is never referenced in the code, just remove it. > > Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com> Thanks, applied now. Takashi
diff --git a/sound/pci/ice1712/prodigy192.c b/sound/pci/ice1712/prodigy192.c index 096ec76f5304..a12dafbf53ab 100644 --- a/sound/pci/ice1712/prodigy192.c +++ b/sound/pci/ice1712/prodigy192.c @@ -170,14 +170,9 @@ static int stac9460_dac_vol_put(struct snd_kcontrol *kcontrol, struct snd_ctl_el tmp = stac9460_get(ice, idx); ovol = 0x7f - (tmp & 0x7f); change = (ovol != nvol); - if (change) { - ovol = (0x7f - nvol) | (tmp & 0x80); - /* - dev_dbg(ice->card->dev, "DAC Volume: reg 0x%02x: 0x%02x\n", - idx, ovol); - */ + if (change) stac9460_put(ice, idx, (0x7f - nvol) | (tmp & 0x80)); - } + return change; }
The variable 'ovol' is never referenced in the code, just remove it. Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com> --- sound/pci/ice1712/prodigy192.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)