| Message ID | 20241009073211.7266-1-zhujun2@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ALSA: scarlett2: Add error check after retrieving PEQ filter values | expand |
> Add error check after retrieving PEQ filter values in scarlett2_update_filter_values > that ensure function returns error if PEQ filter value retrieval fails * It is usually preferred to end such a sentence with a dot, isn't it? * Would you like to add any tags (like “Fixes” and “Cc”) accordingly? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n145 … > --- > sound/usb/mixer_scarlett2.c | 3 +++ Please take version information better into account. See also: * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n321 * https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22 … > +++ b/sound/usb/mixer_scarlett2.c > @@ -5614,6 +5614,9 @@ static int scarlett2_update_filter_values(struct usb_mixer_interface *mixer) > SCARLETT2_BIQUAD_COEFFS, > peq_flt_values); > > + if (err < 0) > + return err; > + > for (i = 0, dst_idx = 0; i < info->dsp_input_count; i++) { … May a blank line be omitted before the return value check? Regards, Markus
diff --git a/sound/usb/mixer_scarlett2.c b/sound/usb/mixer_scarlett2.c index 1150cf104985..1b864a9621ba 100644 --- a/sound/usb/mixer_scarlett2.c +++ b/sound/usb/mixer_scarlett2.c @@ -5614,6 +5614,9 @@ static int scarlett2_update_filter_values(struct usb_mixer_interface *mixer) SCARLETT2_BIQUAD_COEFFS, peq_flt_values); + if (err < 0) + return err; + for (i = 0, dst_idx = 0; i < info->dsp_input_count; i++) { src_idx = i * info->peq_flt_total_count *
Add error check after retrieving PEQ filter values in scarlett2_update_filter_values that ensure function returns error if PEQ filter value retrieval fails Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com> --- sound/usb/mixer_scarlett2.c | 3 +++ 1 file changed, 3 insertions(+)