| Message ID | 20241016080713.46801-1-kovalev@altlinux.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 164cd0e077a18d6208523c82b102c98c77fdd51f |
| Headers | show |
| Series | ALSA: hda/conexant - Use cached pin control for Node 0x1d on HP EliteOne 1000 G2 | expand |
On Wed, 16 Oct 2024 10:07:13 +0200, Vasiliy Kovalev wrote: > > The cached version avoids redundant commands to the codec, improving > stability and reducing unnecessary operations. This change ensures > better power management and reliable restoration of pin configurations, > especially after hibernation (S4) and other power transitions. > > Fixes: 9988844c457f ("ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2") > Suggested-by: Kai-Heng Feng <kaihengf@nvidia.com> > Suggested-by: Takashi Iwai <tiwai@suse.de> > Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> Applied now. Thanks. Takashi
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 3a647f3c65d1b..e7107a14fa9dc 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -330,7 +330,7 @@ static void cxt_fixup_update_pinctl(struct hda_codec *codec, * This is the value stored in the codec register after * the correct initialization of the previous windows boot. */ - snd_hda_set_pin_ctl(codec, 0x1d, AC_PINCTL_HP_EN); + snd_hda_set_pin_ctl_cache(codec, 0x1d, AC_PINCTL_HP_EN); } }
The cached version avoids redundant commands to the codec, improving stability and reducing unnecessary operations. This change ensures better power management and reliable restoration of pin configurations, especially after hibernation (S4) and other power transitions. Fixes: 9988844c457f ("ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2") Suggested-by: Kai-Heng Feng <kaihengf@nvidia.com> Suggested-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> --- sound/pci/hda/patch_conexant.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)