| Message ID | 20241018094320.113477-2-wangweidong.a@awinic.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: codecs: Add aw88081 amplifier driver | expand |
On 18/10/2024 11:43, wangweidong.a@awinic.com wrote: > From: Weidong Wang <wangweidong.a@awinic.com> > > Add the awinic,aw88081 property to the awinic,aw88395.yaml file. > > Signed-off-by: Weidong Wang <wangweidong.a@awinic.com> > --- > Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml > index ac5f2e0f42cb..b39c76b685f4 100644 > --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml > +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml > @@ -20,6 +20,7 @@ properties: > - awinic,aw88395 > - awinic,aw88261 > - awinic,aw88399 > + - awinic,aw88081 I am sorry, but what type of sorting are you keeping here? It looks entirely random. Best regards, Krzysztof
On Fri, Oct 18, 2024 at 05:43:18PM +0800, wangweidong.a@awinic.com wrote: > From: Weidong Wang <wangweidong.a@awinic.com> > > Add the awinic,aw88081 property to the awinic,aw88395.yaml file. That is obvious from reading the diff. Please say something about how this new part compares to the existing parts. > > Signed-off-by: Weidong Wang <wangweidong.a@awinic.com> > --- > Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml > index ac5f2e0f42cb..b39c76b685f4 100644 > --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml > +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml > @@ -20,6 +20,7 @@ properties: > - awinic,aw88395 > - awinic,aw88261 > - awinic,aw88399 > + - awinic,aw88081 > > reg: > maxItems: 1 > @@ -57,6 +58,7 @@ allOf: > contains: > enum: > - awinic,aw88261 > + - awinic,aw88081 > then: > properties: > reset-gpios: false > -- > 2.47.0 >
On Fri, Oct 18, 2024 at 12:08:08PM +0200, krzysztof.kozlowski@linaro.org wrote: > On 18/10/2024 11:43, wangweidong.a@awinic.com wrote: >> From: Weidong Wang <wangweidong.a@awinic.com> >> >> Add the awinic,aw88081 property to the awinic,aw88395.yaml file. >> >> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com> >> --- >> Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml >> index ac5f2e0f42cb..b39c76b685f4 100644 >> --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml >> +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml >> @@ -20,6 +20,7 @@ properties: >> - awinic,aw88395 >> - awinic,aw88261 >> - awinic,aw88399 >> + - awinic,aw88081 > I am sorry, but what type of sorting are you keeping here? It looks > entirely random. Thank you very much for your review. I will change it to - awinic,aw88081 - awinic,aw88261 - awinic,aw88395 - awinic,aw88399 in PATCH V2 Best regards, Weidong Wang
On Fri, Oct 18, 2024 at 08:47:21PM -0500, robh@kernel.org wrote: > On Fri, Oct 18, 2024 at 05:43:18PM +0800, wangweidong.a@awinic.com wrote: >> From: Weidong Wang <wangweidong.a@awinic.com> >> >> Add the awinic,aw88081 property to the awinic,aw88395.yaml file. > That is obvious from reading the diff. Please say something about how > this new part compares to the existing parts. Thank you very much for your review. I will modify the commit message as shown below "Add the awinic,aw88081 property to support the aw88081 chip, which is an I2S/TDM input, high efficiency digital Smart K audio amplifie" >> >> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com> >> --- >> Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml >> index ac5f2e0f42cb..b39c76b685f4 100644 >> --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml >> +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml >> @@ -20,6 +20,7 @@ properties: >> - awinic,aw88395 >> - awinic,aw88261 >> - awinic,aw88399 >> + - awinic,aw88081 >> >> reg: >> maxItems: 1 >> @@ -57,6 +58,7 @@ allOf: >> contains: >> enum: >> - awinic,aw88261 >> + - awinic,aw88081 >> then: >> properties: >> reset-gpios: false >> -- >> 2.47.0 >> Best regards, Weidong Wang
diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml index ac5f2e0f42cb..b39c76b685f4 100644 --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml @@ -20,6 +20,7 @@ properties: - awinic,aw88395 - awinic,aw88261 - awinic,aw88399 + - awinic,aw88081 reg: maxItems: 1 @@ -57,6 +58,7 @@ allOf: contains: enum: - awinic,aw88261 + - awinic,aw88081 then: properties: reset-gpios: false