diff mbox series

ALSA: hda/tas2781: select CRC32 instead of CRC32_SARWATE

Message ID 20241020175624.7095-1-ebiggers@kernel.org (mailing list archive)
State New, archived
Headers show
Series ALSA: hda/tas2781: select CRC32 instead of CRC32_SARWATE | expand

Commit Message

Eric Biggers Oct. 20, 2024, 5:56 p.m. UTC 
From: Eric Biggers <ebiggers@google.com>

Fix the kconfig option for the tas2781 HDA driver to select CRC32 rather
than CRC32_SARWATE.  CRC32_SARWATE is an option from the kconfig
'choice' that selects the specific CRC32 implementation.  Selecting a
'choice' option seems to have no effect, but even if it did work, it
would be incorrect for a random driver to override the user's choice.
CRC32 is the correct option to select for crc32() to be available.

Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 sound/pci/hda/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 715ca9dd687f89ddaac8ec8ccb3b5e5a30311a99

Comments

Takashi Iwai Oct. 21, 2024, 7:21 a.m. UTC | #1 
On Sun, 20 Oct 2024 19:56:24 +0200,
Eric Biggers wrote:
> 
> From: Eric Biggers <ebiggers@google.com>
> 
> Fix the kconfig option for the tas2781 HDA driver to select CRC32 rather
> than CRC32_SARWATE.  CRC32_SARWATE is an option from the kconfig
> 'choice' that selects the specific CRC32 implementation.  Selecting a
> 'choice' option seems to have no effect, but even if it did work, it
> would be incorrect for a random driver to override the user's choice.
> CRC32 is the correct option to select for crc32() to be available.
> 
> Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Thanks, applied now.


Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
index bb15a0248250c..68f1eee9e5c93 100644
--- a/sound/pci/hda/Kconfig
+++ b/sound/pci/hda/Kconfig
@@ -196,11 +196,11 @@  config SND_HDA_SCODEC_TAS2781_I2C
 	depends on ACPI
 	depends on EFI
 	depends on SND_SOC
 	select SND_SOC_TAS2781_COMLIB
 	select SND_SOC_TAS2781_FMWLIB
-	select CRC32_SARWATE
+	select CRC32
 	help
 	  Say Y or M here to include TAS2781 I2C HD-audio side codec support
 	  in snd-hda-intel driver, such as ALC287.
 
 comment "Set to Y if you want auto-loading the side codec driver"