| Message ID | 20241029221249.15661-1-jan@jschaer.ch (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4413665dd6c528b31284119e3571c25f371e1c36 |
| Headers | show |
| Series | ALSA: usb-audio: Add quirks for Dell WD19 dock | expand |
On Tue, 29 Oct 2024 23:12:49 +0100, Jan Schär wrote: > > The WD19 family of docks has the same audio chipset as the WD15. This > change enables jack detection on the WD19. > > We don't need the dell_dock_mixer_init quirk for the WD19. It is only > needed because of the dell_alc4020_map quirk for the WD15 in > mixer_maps.c, which disables the volume controls. Even for the WD15, > this quirk was apparently only needed when the dock firmware was not > updated. > > Signed-off-by: Jan Schär <jan@jschaer.ch> Thanks, applied now. Takashi
diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index 2a9594f34dac..6456e87e2f39 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -4042,6 +4042,9 @@ int snd_usb_mixer_apply_create_quirk(struct usb_mixer_interface *mixer) break; err = dell_dock_mixer_init(mixer); break; + case USB_ID(0x0bda, 0x402e): /* Dell WD19 dock */ + err = dell_dock_mixer_create(mixer); + break; case USB_ID(0x2a39, 0x3fd2): /* RME ADI-2 Pro */ case USB_ID(0x2a39, 0x3fd3): /* RME ADI-2 DAC */
The WD19 family of docks has the same audio chipset as the WD15. This change enables jack detection on the WD19. We don't need the dell_dock_mixer_init quirk for the WD19. It is only needed because of the dell_alc4020_map quirk for the WD15 in mixer_maps.c, which disables the volume controls. Even for the WD15, this quirk was apparently only needed when the dock firmware was not updated. Signed-off-by: Jan Schär <jan@jschaer.ch> --- sound/usb/mixer_quirks.c | 3 +++ 1 file changed, 3 insertions(+) base-commit: 583e8f76410a5b7e0238426d8e6e1e1d2f4994b0