| Message ID | 20241112125646.590240-1-ckeepax@opensource.cirrus.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND,1/2] soundwire: Update the includes on the sdw.h header | expand |
On Tue, 12 Nov 2024 12:56:45 +0000, Charles Keepax wrote: > There are quite a few things used in the sdw.h header that it relies on > the consumer to include. If something is used directly in the header it > should be included by the header. Update the includes to cover the > missing items, or add forward declarations for things that are only used > as pointers. Whilst making the change also alphabetise the list of > includes. > > [...] Applied, thanks! [1/2] soundwire: Update the includes on the sdw.h header commit: e311b04db66aaed1819bdd479d42c4f338f105b9 [2/2] soundwire: Minor formatting fixups in sdw.h header commit: dd690b31de0ed46adc5856698880560b900386ba Best regards,
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h index 73f655334fe9c..1fd4b126287f2 100644 --- a/include/linux/soundwire/sdw.h +++ b/include/linux/soundwire/sdw.h @@ -4,12 +4,19 @@ #ifndef __SOUNDWIRE_H #define __SOUNDWIRE_H +#include <linux/bitfield.h> #include <linux/bug.h> -#include <linux/lockdep_types.h> +#include <linux/completion.h> +#include <linux/device.h> #include <linux/irq.h> #include <linux/irqdomain.h> +#include <linux/lockdep_types.h> #include <linux/mod_devicetable.h> -#include <linux/bitfield.h> +#include <linux/mutex.h> +#include <linux/types.h> + +struct dentry; +struct fwnode_handle; struct sdw_bus; struct sdw_slave;
There are quite a few things used in the sdw.h header that it relies on the consumer to include. If something is used directly in the header it should be included by the header. Update the includes to cover the missing items, or add forward declarations for things that are only used as pointers. Whilst making the change also alphabetise the list of includes. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- include/linux/soundwire/sdw.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)