| Message ID | 20241202144659.1553504-1-chris.chiu@canonical.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ALSA: hda/realtek: fix micmute LEDs don't work on HP Laptops | expand |
On Mon, 2 Dec 2024 14:47:00 +0000, Chris Chiu wrote: > These HP laptops use Realtek HDA codec ALC3315 combined CS35L56 > Amplifiers. They need the quirk ALC285_FIXUP_HP_GPIO_LED to get > the micmute LED working. > > Signed-off-by: Chris Chiu <chris.chiu@canonical.com> Reviewed-by: Simon Trimmer <simont@opensource.cirrus.com> > --- > sound/pci/hda/patch_realtek.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 2bf5c512ebaf..237e0c17083b 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -10521,7 +10521,13 @@ static const struct hda_quirk > alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x8cdf, "HP SnowWhite", > ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8ce0, "HP SnowWhite", > ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", > ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x8d01, "HP ZBook Power 14 G12", > ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8d84, "HP EliteBook X G1i", > ALC285_FIXUP_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x8d91, "HP ZBook Firefly 14 G12", > ALC285_FIXUP_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x8d92, "HP ZBook Firefly 16 G12", > ALC285_FIXUP_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x8e18, "HP ZBook Firefly 14 G12A", > ALC285_FIXUP_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x8e19, "HP ZBook Firelfy 14 G12A", > ALC285_FIXUP_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x8e1a, "HP ZBook Firefly 14 G12A", > ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", > ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", > ALC282_FIXUP_ASUS_TX300), > SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", > ALC269_FIXUP_LIMIT_INT_MIC_BOOST), > -- > 2.34.1 >
On Mon, 02 Dec 2024 15:46:59 +0100, Chris Chiu wrote: > > These HP laptops use Realtek HDA codec ALC3315 combined CS35L56 > Amplifiers. They need the quirk ALC285_FIXUP_HP_GPIO_LED to get > the micmute LED working. > > Signed-off-by: Chris Chiu <chris.chiu@canonical.com> Thanks, applied now. Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 2bf5c512ebaf..237e0c17083b 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10521,7 +10521,13 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8cdf, "HP SnowWhite", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8ce0, "HP SnowWhite", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8d01, "HP ZBook Power 14 G12", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8d84, "HP EliteBook X G1i", ALC285_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8d91, "HP ZBook Firefly 14 G12", ALC285_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8d92, "HP ZBook Firefly 16 G12", ALC285_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8e18, "HP ZBook Firefly 14 G12A", ALC285_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8e19, "HP ZBook Firelfy 14 G12A", ALC285_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8e1a, "HP ZBook Firefly 14 G12A", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
These HP laptops use Realtek HDA codec ALC3315 combined CS35L56 Amplifiers. They need the quirk ALC285_FIXUP_HP_GPIO_LED to get the micmute LED working. Signed-off-by: Chris Chiu <chris.chiu@canonical.com> --- sound/pci/hda/patch_realtek.c | 6 ++++++ 1 file changed, 6 insertions(+)