| Message ID | 20250127150458.1489425-1-megi@xff.cz (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6c1bb4031729871fa203983bd77bed1ee3c61347 |
| Headers | show |
| Series | ASoC: codec: es8316: "DAC Soft Ramp Rate" is just a 2 bit control | expand |
On Mon, Jan 27, 2025 at 04:04:55PM +0100, Ondřej Jirman wrote: > From: Ondrej Jirman <megi@xff.cz> > > Max value should be 3, otherwise "DAC Soft Ramp Switch" will be > overwritten by this control. We should probably have something to check this during registration, possibly also have mixer-test check for other controls changing when we change one (there will be some things that trigger on it due to bodging things for stereo paths on some older devices but I don't know that that's a widespread issues).
On Mon, 27 Jan 2025 16:04:55 +0100, Ondřej Jirman wrote: > Max value should be 3, otherwise "DAC Soft Ramp Switch" will be > overwritten by this control. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: codec: es8316: "DAC Soft Ramp Rate" is just a 2 bit control commit: 6c1bb4031729871fa203983bd77bed1ee3c61347 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c index f508df01145b..e7bd561a8f40 100644 --- a/sound/soc/codecs/es8316.c +++ b/sound/soc/codecs/es8316.c @@ -101,7 +101,7 @@ static const struct snd_kcontrol_new es8316_snd_controls[] = { SOC_DOUBLE_R_TLV("DAC Playback Volume", ES8316_DAC_VOLL, ES8316_DAC_VOLR, 0, 0xc0, 1, dac_vol_tlv), SOC_SINGLE("DAC Soft Ramp Switch", ES8316_DAC_SET1, 4, 1, 1), - SOC_SINGLE("DAC Soft Ramp Rate", ES8316_DAC_SET1, 2, 4, 0), + SOC_SINGLE("DAC Soft Ramp Rate", ES8316_DAC_SET1, 2, 3, 0), SOC_SINGLE("DAC Notch Filter Switch", ES8316_DAC_SET2, 6, 1, 0), SOC_SINGLE("DAC Double Fs Switch", ES8316_DAC_SET2, 7, 1, 0), SOC_SINGLE("DAC Stereo Enhancement", ES8316_DAC_SET3, 0, 7, 0),