| Message ID | 20250220112643.3813295-7-cezary.rojewski@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: codecs: Update device_id tables for Realtek drivers | expand |
On Thu, Feb 20, 2025 at 12:26:25PM +0100, Cezary Rojewski wrote: > There shall be no comma after the terminator entry and initializing > fields with 0 for statically defined structs is redundant. ... > + { } > + {} I think you want a bit of consistency in the style of the terminator. Preferable (by majority) is with space inside, but some are okay without it. I have no preferences, just one style for all in the same driver.
On 2025-02-20 3:11 PM, Andy Shevchenko wrote: > On Thu, Feb 20, 2025 at 12:26:25PM +0100, Cezary Rojewski wrote: >> There shall be no comma after the terminator entry and initializing >> fields with 0 for statically defined structs is redundant. > > ... > >> + { } > >> + {} > > I think you want a bit of consistency in the style of the terminator. > Preferable (by majority) is with space inside, but some are okay without it. > I have no preferences, just one style for all in the same driver. Ack. What happened is: in some cases I just updated the line according to the standard whereas in others I did remove ',' and other stuff while aligning with my spacing preference. Will pick one for v2. Czarek
diff --git a/sound/soc/codecs/rt1308.c b/sound/soc/codecs/rt1308.c index b366338cea71..a9ba66228301 100644 --- a/sound/soc/codecs/rt1308.c +++ b/sound/soc/codecs/rt1308.c @@ -781,15 +781,15 @@ static const struct regmap_config rt1308_regmap = { #ifdef CONFIG_OF static const struct of_device_id rt1308_of_match[] = { { .compatible = "realtek,rt1308", }, - { }, + { } }; MODULE_DEVICE_TABLE(of, rt1308_of_match); #endif #ifdef CONFIG_ACPI static const struct acpi_device_id rt1308_acpi_match[] = { - { "10EC1308", 0, }, - { }, + { "10EC1308" }, + {} }; MODULE_DEVICE_TABLE(acpi, rt1308_acpi_match); #endif
There shall be no comma after the terminator entry and initializing fields with 0 for statically defined structs is redundant. Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> --- sound/soc/codecs/rt1308.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)