| Message ID | 20250220165127.492927-1-superm1@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: SOF: amd: Add depends on CPU_SUP_AMD | expand |
On Thu, Feb 20, 2025 at 10:51:26AM -0600, Mario Limonciello wrote: > From: Mario Limonciello <mario.limonciello@amd.com> > > When SMN support was switched to the kernel wide AMD_NODE instead of > local implementation this broke compilation on the allyesconfig for > some architectures. AMD_NODE is only supported on AMD platforms, so > modify all the AMD drivers that use it to also require CPU_SUP_AMD. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Closes: https://lore.kernel.org/linux-next/20250220160950.2cd64bdb@canb.auug.org.au/ > Fixes: f120cf33d232 ("ASoC: SOF: amd: Use AMD_NODE") > --- You've not provided a Signed-off-by for this so I can't do anything with it, please see Documentation/process/submitting-patches.rst for details on what this is and why it's important.
On 2/20/2025 12:43, Mark Brown wrote: > On Thu, Feb 20, 2025 at 10:51:26AM -0600, Mario Limonciello wrote: >> From: Mario Limonciello <mario.limonciello@amd.com> >> >> When SMN support was switched to the kernel wide AMD_NODE instead of >> local implementation this broke compilation on the allyesconfig for >> some architectures. AMD_NODE is only supported on AMD platforms, so >> modify all the AMD drivers that use it to also require CPU_SUP_AMD. >> >> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> >> Closes: https://lore.kernel.org/linux-next/20250220160950.2cd64bdb@canb.auug.org.au/ >> Fixes: f120cf33d232 ("ASoC: SOF: amd: Use AMD_NODE") >> --- > > You've not provided a Signed-off-by for this so I can't do anything with > it, please see Documentation/process/submitting-patches.rst for details > on what this is and why it's important. Whoops, sorry about that, will resend.
diff --git a/sound/soc/sof/amd/Kconfig b/sound/soc/sof/amd/Kconfig index 28216c8c1cf97..6eb5b2d148430 100644 --- a/sound/soc/sof/amd/Kconfig +++ b/sound/soc/sof/amd/Kconfig @@ -33,6 +33,7 @@ config SND_SOC_SOF_AMD_COMMON config SND_SOC_SOF_AMD_RENOIR tristate "SOF support for RENOIR" depends on SND_SOC_SOF_PCI + depends on CPU_SUP_AMD select SND_SOC_SOF_AMD_COMMON help Select this option for SOF support on AMD Renoir platform @@ -40,6 +41,7 @@ config SND_SOC_SOF_AMD_RENOIR config SND_SOC_SOF_AMD_VANGOGH tristate "SOF support for VANGOGH" depends on SND_SOC_SOF_PCI + depends on CPU_SUP_AMD select SND_SOC_SOF_AMD_COMMON help Select this option for SOF support @@ -50,6 +52,7 @@ config SND_SOC_SOF_AMD_VANGOGH config SND_SOC_SOF_AMD_REMBRANDT tristate "SOF support for REMBRANDT" depends on SND_SOC_SOF_PCI + depends on CPU_SUP_AMD select SND_SOC_SOF_AMD_COMMON help Select this option for SOF support on AMD Rembrandt platform @@ -82,6 +85,7 @@ config SND_SOC_SOF_AMD_SOUNDWIRE config SND_SOC_SOF_AMD_ACP63 tristate "SOF support for ACP6.3 platform" depends on SND_SOC_SOF_PCI + depends on CPU_SUP_AMD select SND_SOC_SOF_AMD_COMMON select SND_SOC_SOF_AMD_SOUNDWIRE_LINK_BASELINE help @@ -93,6 +97,7 @@ config SND_SOC_SOF_AMD_ACP63 config SND_SOC_SOF_AMD_ACP70 tristate "SOF support for ACP7.0 platform" depends on SND_SOC_SOF_PCI + depends on CPU_SUP_AMD select SND_SOC_SOF_AMD_COMMON help Select this option for SOF support on
From: Mario Limonciello <mario.limonciello@amd.com> When SMN support was switched to the kernel wide AMD_NODE instead of local implementation this broke compilation on the allyesconfig for some architectures. AMD_NODE is only supported on AMD platforms, so modify all the AMD drivers that use it to also require CPU_SUP_AMD. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Closes: https://lore.kernel.org/linux-next/20250220160950.2cd64bdb@canb.auug.org.au/ Fixes: f120cf33d232 ("ASoC: SOF: amd: Use AMD_NODE") --- sound/soc/sof/amd/Kconfig | 5 +++++ 1 file changed, 5 insertions(+)