From patchwork Mon Jan 15 05:11:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 10163065 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 51E0C60245 for ; Mon, 15 Jan 2018 05:21:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C5C128975 for ; Mon, 15 Jan 2018 05:21:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2CE852897B; Mon, 15 Jan 2018 05:21:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EC7F28975 for ; Mon, 15 Jan 2018 05:21:49 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id A01C1267332; Mon, 15 Jan 2018 06:12:10 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5A36126734C; Mon, 15 Jan 2018 06:12:09 +0100 (CET) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by alsa0.perex.cz (Postfix) with ESMTP id A130D26731C for ; Mon, 15 Jan 2018 06:12:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Date:Message-ID:Cc:To:Subject:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DtpqktfsquGImYZz7+DnYqaKifbv8QZDdSwrs2y6lPk=; b=evgfoVh7f4Apk25Y5cG5HUEHw7 9WQDlsdaj9AZQm379bQ7gNBWQMKfbEG5SE3/9YinXpTHgziglTpvQbx1NY0xQCwwGkXHG6xFVBVqx X+7VJC2v5TjcwU/TNSqXXs5dR0Fow8jozWPQ55eqw9c+BWzPbRfNEz+HsXrKneOTC0d8/ebH4TuBI Hs+CelIu+AqpXGMNKc98JukQ5cTmGY4AIGsRtyWCUhsi2fFLNBC1rk91ObUUraTOCd0az/IekONo2 5p/I7pPrJYnInOj+Rs4g1jmXBfjLRD/UlDmSoDwcJ4nDohBH3bEX+ok4q0nLy1d89WdMsS6bVabh/ 7FkvNQjA==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=dragon.site) by merlin.infradead.org with esmtpsa (Exim 4.89 #1 (Red Hat Linux)) id 1eax3t-0003qU-VN; Mon, 15 Jan 2018 05:11:58 +0000 From: Randy Dunlap To: moderated for non-subscribers , LKML Message-ID: <254bab8e-5629-0dc0-5a4e-9a010abf9ad8@infradead.org> Date: Sun, 14 Jan 2018 21:11:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Language: en-US Cc: Takashi Iwai Subject: [alsa-devel] [PATCH] sound/pci/hda: depends on instead of select for INPUT X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap Drivers should not 'select' a subsystem. Instead they should depend on it. If the subsystem is disabled, the user probably did that for a purpose and one driver shouldn't be changing that. This also makes all sound/ drivers consistent w.r.t depending on INPUT instead of selecting it. Signed-off-by: Randy Dunlap Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-devel@alsa-project.org (moderated for non-subscribers) --- sound/pci/hda/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- lnx-415-rc8.orig/sound/pci/hda/Kconfig +++ lnx-415-rc8/sound/pci/hda/Kconfig @@ -87,8 +87,8 @@ config SND_HDA_PATCH_LOADER config SND_HDA_CODEC_REALTEK tristate "Build Realtek HD-audio codec support" + depends on INPUT select SND_HDA_GENERIC - select INPUT help Say Y or M here to include Realtek HD-audio codec support in snd-hda-intel driver, such as ALC880.