| Message ID | 2fb55d48-6991-4a42-b591-4c78f2fad8d7@pelago.org.uk (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] ALSA: hda/conexant: Add quirk for HP ProBook 450 G4 mute LED | expand |
On Mon, 17 Feb 2025 13:15:50 +0100, John Veness wrote: > > Allows the LED on the dedicated mute button on the HP ProBook 450 G4 > laptop to change colour correctly. > > Signed-off-by: John Veness <john-linux@pelago.org.uk> > --- > Re-submitted with correct tabs (I hope!) Now the patch is cleanly applicable, so I took now. But, the Cc-to-stable should have been put in the patch itself (around your Signed-off-by line). I put it locally. thanks, Takashi > > sound/pci/hda/patch_conexant.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c > index 4985e72b9..34874039a 100644 > --- a/sound/pci/hda/patch_conexant.c > +++ b/sound/pci/hda/patch_conexant.c > @@ -1090,6 +1090,7 @@ static const struct hda_quirk cxt5066_fixups[] = { > SND_PCI_QUIRK(0x103c, 0x814f, "HP ZBook 15u G3", CXT_FIXUP_MUTE_LED_GPIO), > SND_PCI_QUIRK(0x103c, 0x8174, "HP Spectre x360", CXT_FIXUP_HP_SPECTRE), > SND_PCI_QUIRK(0x103c, 0x822e, "HP ProBook 440 G4", CXT_FIXUP_MUTE_LED_GPIO), > + SND_PCI_QUIRK(0x103c, 0x8231, "HP ProBook 450 G4", CXT_FIXUP_MUTE_LED_GPIO), > SND_PCI_QUIRK(0x103c, 0x828c, "HP EliteBook 840 G4", CXT_FIXUP_HP_DOCK), > SND_PCI_QUIRK(0x103c, 0x8299, "HP 800 G3 SFF", CXT_FIXUP_HP_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x103c, 0x829a, "HP 800 G3 DM", CXT_FIXUP_HP_MIC_NO_PRESENCE), > -- > 2.48.1
On 17/02/2025 12:25, Takashi Iwai wrote: > On Mon, 17 Feb 2025 13:15:50 +0100, > John Veness wrote: >> >> Allows the LED on the dedicated mute button on the HP ProBook 450 G4 >> laptop to change colour correctly. >> >> Signed-off-by: John Veness <john-linux@pelago.org.uk> >> --- >> Re-submitted with correct tabs (I hope!) > > Now the patch is cleanly applicable, so I took now. > But, the Cc-to-stable should have been put in the patch itself (around > your Signed-off-by line). I put it locally. Whoops, I just submitted a v3 to fix the stable CC, after "kernel test robot" alerted me. I hope that doesn't mess things up. John > thanks, > > Takashi > >> >> sound/pci/hda/patch_conexant.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c >> index 4985e72b9..34874039a 100644 >> --- a/sound/pci/hda/patch_conexant.c >> +++ b/sound/pci/hda/patch_conexant.c >> @@ -1090,6 +1090,7 @@ static const struct hda_quirk cxt5066_fixups[] = { >> SND_PCI_QUIRK(0x103c, 0x814f, "HP ZBook 15u G3", CXT_FIXUP_MUTE_LED_GPIO), >> SND_PCI_QUIRK(0x103c, 0x8174, "HP Spectre x360", CXT_FIXUP_HP_SPECTRE), >> SND_PCI_QUIRK(0x103c, 0x822e, "HP ProBook 440 G4", CXT_FIXUP_MUTE_LED_GPIO), >> + SND_PCI_QUIRK(0x103c, 0x8231, "HP ProBook 450 G4", CXT_FIXUP_MUTE_LED_GPIO), >> SND_PCI_QUIRK(0x103c, 0x828c, "HP EliteBook 840 G4", CXT_FIXUP_HP_DOCK), >> SND_PCI_QUIRK(0x103c, 0x8299, "HP 800 G3 SFF", CXT_FIXUP_HP_MIC_NO_PRESENCE), >> SND_PCI_QUIRK(0x103c, 0x829a, "HP 800 G3 DM", CXT_FIXUP_HP_MIC_NO_PRESENCE), >> -- >> 2.48.1
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 4985e72b9..34874039a 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -1090,6 +1090,7 @@ static const struct hda_quirk cxt5066_fixups[] = { SND_PCI_QUIRK(0x103c, 0x814f, "HP ZBook 15u G3", CXT_FIXUP_MUTE_LED_GPIO), SND_PCI_QUIRK(0x103c, 0x8174, "HP Spectre x360", CXT_FIXUP_HP_SPECTRE), SND_PCI_QUIRK(0x103c, 0x822e, "HP ProBook 440 G4", CXT_FIXUP_MUTE_LED_GPIO), + SND_PCI_QUIRK(0x103c, 0x8231, "HP ProBook 450 G4", CXT_FIXUP_MUTE_LED_GPIO), SND_PCI_QUIRK(0x103c, 0x828c, "HP EliteBook 840 G4", CXT_FIXUP_HP_DOCK), SND_PCI_QUIRK(0x103c, 0x8299, "HP 800 G3 SFF", CXT_FIXUP_HP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x829a, "HP 800 G3 DM", CXT_FIXUP_HP_MIC_NO_PRESENCE),
Allows the LED on the dedicated mute button on the HP ProBook 450 G4 laptop to change colour correctly. Signed-off-by: John Veness <john-linux@pelago.org.uk> --- Re-submitted with correct tabs (I hope!) sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+)