| Message ID | 390287d1-ddce-4414-873d-44ac0186a14c@kili.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] soundwire: amd: fix an error check in probe() | expand |
diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c index 9fb7f91ca182..21c638e38c51 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -910,9 +910,9 @@ static int amd_sdw_manager_probe(struct platform_device *pdev) return -ENOMEM; amd_manager->acp_mmio = devm_ioremap(dev, res->start, resource_size(res)); - if (IS_ERR(amd_manager->mmio)) { + if (!amd_manager->acp_mmio) { dev_err(dev, "mmio not found\n"); - return PTR_ERR(amd_manager->mmio); + return -ENOMEM; } amd_manager->instance = pdata->instance; amd_manager->mmio = amd_manager->acp_mmio +
This code is testing the wrong variable. It should be ->acp_mmio instead of ->mmio. It also should be a NULL check instead of an IS_ERR() check. Fixes: a673a8dfc214 ("soundwire: amd: Add support for AMD Manager driver") Signed-off-by: Dan Carpenter <error27@gmail.com> --- v2: My first patch just fixed the NULL vs IS_ERR() but because it was using the wrong variable that broke the driver completely. Thanks, Vijendar for finding this: Fixes-from: Vijendar Mukunda <Vijendar.Mukunda@amd.com> drivers/soundwire/amd_manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)