| Message ID | 5306B791.4030101@sakamocchi.jp (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Takashi Iwai |
| Headers | show |
At Fri, 21 Feb 2014 11:18:57 +0900, Takashi Sakamoto wrote: > > >From 1cc92cabd87472deb58a461344c0d70b3ecd93bd Mon Sep 17 00:00:00 2001 > From: Takashi Sakamoto <o-takashi@sakamocchi.jp> > Date: Thu, 20 Feb 2014 23:45:39 +0900 > Subject: [PATCH] rawmidi: remove undefined functions. > > 'snd_rawmidi_transmit_reset()' and 'snd_rawmidi_receive_reset()' are declared > but not defined. > > This state has been continue over 10 years. So let us remove them. > > Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Thanks, applied. Takashi > --- > include/sound/rawmidi.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/sound/rawmidi.h b/include/sound/rawmidi.h > index adf0885..311dafe 100644 > --- a/include/sound/rawmidi.h > +++ b/include/sound/rawmidi.h > @@ -157,10 +157,8 @@ void snd_rawmidi_set_ops(struct snd_rawmidi *rmidi, int stream, > > /* callbacks */ > > -void snd_rawmidi_receive_reset(struct snd_rawmidi_substream *substream); > int snd_rawmidi_receive(struct snd_rawmidi_substream *substream, > const unsigned char *buffer, int count); > -void snd_rawmidi_transmit_reset(struct snd_rawmidi_substream *substream); > int snd_rawmidi_transmit_empty(struct snd_rawmidi_substream *substream); > int snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream, > unsigned char *buffer, int count); > -- > 1.8.3.2 >
From 1cc92cabd87472deb58a461344c0d70b3ecd93bd Mon Sep 17 00:00:00 2001 From: Takashi Sakamoto <o-takashi@sakamocchi.jp> Date: Thu, 20 Feb 2014 23:45:39 +0900 Subject: [PATCH] rawmidi: remove undefined functions. 'snd_rawmidi_transmit_reset()' and 'snd_rawmidi_receive_reset()' are declared but not defined. This state has been continue over 10 years. So let us remove them. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> --- include/sound/rawmidi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/sound/rawmidi.h b/include/sound/rawmidi.h index adf0885..311dafe 100644 --- a/include/sound/rawmidi.h +++ b/include/sound/rawmidi.h @@ -157,10 +157,8 @@ void snd_rawmidi_set_ops(struct snd_rawmidi *rmidi, int stream, /* callbacks */ -void snd_rawmidi_receive_reset(struct snd_rawmidi_substream *substream); int snd_rawmidi_receive(struct snd_rawmidi_substream *substream, const unsigned char *buffer, int count); -void snd_rawmidi_transmit_reset(struct snd_rawmidi_substream *substream); int snd_rawmidi_transmit_empty(struct snd_rawmidi_substream *substream); int snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream, unsigned char *buffer, int count); -- 1.8.3.2
> Could you give your sign-off? Oops, I forgot it... Would you use attached patch instead of previous one? Thanks Takashi Sakamoto o-takashi@sakamocchi.jp