From patchwork Fri Feb 21 02:18:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Sakamoto X-Patchwork-Id: 3693111 X-Patchwork-Delegate: tiwai@suse.de Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 92C7ABF13A for ; Fri, 21 Feb 2014 02:19:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BA46D20148 for ; Fri, 21 Feb 2014 02:19:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 8566C20179 for ; Fri, 21 Feb 2014 02:19:25 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3323D2619D0; Fri, 21 Feb 2014 03:19:24 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 0E5E126172B; Fri, 21 Feb 2014 03:19:14 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 11967261737; Fri, 21 Feb 2014 03:19:12 +0100 (CET) Received: from smtp301.phy.lolipop.jp (smtp301.phy.lolipop.jp [210.157.22.84]) by alsa0.perex.cz (Postfix) with ESMTP id C377C261718 for ; Fri, 21 Feb 2014 03:19:04 +0100 (CET) Received: from smtp301.phy.lolipop.lan (HELO smtp301.phy.lolipop.jp) (172.17.1.84) (smtp-auth username m12129643-o-takashi, mechanism plain) by smtp301.phy.lolipop.jp (qpsmtpd/0.82) with ESMTPA; Fri, 21 Feb 2014 11:19:00 +0900 Received: from 127.0.0.1 (127.0.0.1) by smtp301.phy.lolipop.jp (LOLIPOP-Fsecure); Fri, 21 Feb 2014 11:18:58 +0900 (JST) X-Virus-Status: clean(LOLIPOP-Fsecure) Message-ID: <5306B791.4030101@sakamocchi.jp> Date: Fri, 21 Feb 2014 11:18:57 +0900 From: Takashi Sakamoto User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Takashi Iwai References: <1392908364-8301-1-git-send-email-o-takashi@sakamocchi.jp> In-Reply-To: Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH] rawmidi: remove undefined functions. X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP > Could you give your sign-off? Oops, I forgot it... Would you use attached patch instead of previous one? Thanks Takashi Sakamoto o-takashi@sakamocchi.jp From 1cc92cabd87472deb58a461344c0d70b3ecd93bd Mon Sep 17 00:00:00 2001 From: Takashi Sakamoto Date: Thu, 20 Feb 2014 23:45:39 +0900 Subject: [PATCH] rawmidi: remove undefined functions. 'snd_rawmidi_transmit_reset()' and 'snd_rawmidi_receive_reset()' are declared but not defined. This state has been continue over 10 years. So let us remove them. Signed-off-by: Takashi Sakamoto --- include/sound/rawmidi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/sound/rawmidi.h b/include/sound/rawmidi.h index adf0885..311dafe 100644 --- a/include/sound/rawmidi.h +++ b/include/sound/rawmidi.h @@ -157,10 +157,8 @@ void snd_rawmidi_set_ops(struct snd_rawmidi *rmidi, int stream, /* callbacks */ -void snd_rawmidi_receive_reset(struct snd_rawmidi_substream *substream); int snd_rawmidi_receive(struct snd_rawmidi_substream *substream, const unsigned char *buffer, int count); -void snd_rawmidi_transmit_reset(struct snd_rawmidi_substream *substream); int snd_rawmidi_transmit_empty(struct snd_rawmidi_substream *substream); int snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream, unsigned char *buffer, int count); -- 1.8.3.2