| Message ID | 548bb7f8-672d-3d95-0d78-cef1c9837a42@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: qcom: MSM8996 depends on COMMON_CLK | expand |
On 10/16/20 10:39 AM, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix a kconfig warning in sound/soc/qcom: > > WARNING: unmet direct dependencies detected for SND_SOC_QDSP6 > Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n] > Selected by [y]: > - SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] > > This is needed because 'select' does not follow dependency chains. > > Fixes: a6f933f63f2f ("ASoC: qcom: apq8096: Add db820c machine driver") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: Takashi Iwai <tiwai@suse.com> > Cc: alsa-devel@alsa-project.org > --- > Found in linux-next but applies to mainline. > > sound/soc/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20201016.orig/sound/soc/qcom/Kconfig > +++ linux-next-20201016/sound/soc/qcom/Kconfig > @@ -106,6 +106,7 @@ config SND_SOC_QDSP6 > config SND_SOC_MSM8996 > tristate "SoC Machine driver for MSM8996 and APQ8096 boards" > depends on QCOM_APR > + depends on COMMON_CLK > select SND_SOC_QDSP6 > select SND_SOC_QCOM_COMMON > help > Ping. I am still seeing this kconfig warning in linux-next 20201030.
On Fri, Oct 30, 2020 at 11:31:25AM -0700, Randy Dunlap wrote:
> Ping. I am still seeing this kconfig warning in linux-next 20201030.
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.
--- linux-next-20201016.orig/sound/soc/qcom/Kconfig +++ linux-next-20201016/sound/soc/qcom/Kconfig @@ -106,6 +106,7 @@ config SND_SOC_QDSP6 config SND_SOC_MSM8996 tristate "SoC Machine driver for MSM8996 and APQ8096 boards" depends on QCOM_APR + depends on COMMON_CLK select SND_SOC_QDSP6 select SND_SOC_QCOM_COMMON help