From patchwork Thu Apr 9 07:39:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lars-Peter Clausen X-Patchwork-Id: 6183901 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 98C049F2E9 for ; Thu, 9 Apr 2015 07:39:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F1F07203E3 for ; Thu, 9 Apr 2015 07:39:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id C7396203B7 for ; Thu, 9 Apr 2015 07:39:26 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9C348265726; Thu, 9 Apr 2015 09:39:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id BE686261A3B; Thu, 9 Apr 2015 09:39:16 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id CDC32264FE7; Thu, 9 Apr 2015 09:39:15 +0200 (CEST) Received: from smtp-out-026.synserver.de (smtp-out-026.synserver.de [212.40.185.26]) by alsa0.perex.cz (Postfix) with ESMTP id 65A4A261600 for ; Thu, 9 Apr 2015 09:39:09 +0200 (CEST) Received: (qmail 7534 invoked by uid 0); 9 Apr 2015 07:39:09 -0000 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 7419 Received: from p4fde600a.dip0.t-ipconnect.de (HELO ?192.168.2.103?) [79.222.96.10] by 217.119.54.96 with AES128-SHA encrypted SMTP; 9 Apr 2015 07:39:08 -0000 Message-ID: <55262C9D.5080005@metafoo.de> Date: Thu, 09 Apr 2015 09:39:09 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Fabio Estevam References: <55258272.2010205@metafoo.de> In-Reply-To: Cc: Nicolin Chen , "alsa-devel@alsa-project.org" , Mark Brown , Russell King Subject: Re: [alsa-devel] ASoC: Failed to create DAPM debugfs X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On 04/08/2015 10:35 PM, Fabio Estevam wrote: > On Wed, Apr 8, 2015 at 4:33 PM, Lars-Peter Clausen wrote: > >> Does the card name contain a '/' like in 'S/PDIF'? > > Yes, it does. I also tried to change it like this: > > --- a/sound/soc/fsl/imx-spdif.c > +++ b/sound/soc/fsl/imx-spdif.c > @@ -37,8 +37,8 @@ static int imx_spdif_audio_probe(struct platform_device *pdev) > goto end; > } > > - data->dai.name = "S/PDIF PCM"; > - data->dai.stream_name = "S/PDIF PCM"; > + data->dai.name = "SPDIF PCM"; > + data->dai.stream_name = "SPDIF PCM"; > data->dai.codec_dai_name = "snd-soc-dummy-dai"; > data->dai.codec_name = "snd-soc-dummy"; > data->dai.cpu_of_node = spdif_np; > > ,but I still get the warning. That's the DAI name, which could cause problems on its own. But not the one you are seeing right now. The whole thing is a bit confusing. The message you get is what you'd get if the 'dapm' sub-directory in the card debugfs directory can not be created. One of the few reasons why it would fail is if it already existed, but we should never register two dapm contexts for the card, so that's a bit strange. One of the few reasons I can imagine this could happen is if the parent directory could not be created and now we try to create multiple dapm directories at the top-level. Try to do some more debugging and see why and where exactly things go wrong. Can you also try this: diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index b6f8820..7810262 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -1898,6 +1898,11 @@ { struct dentry *d; + if (!parent) { + dev_warn(dapm->dev, "No debugfs parent!\n"); + return; + } + dapm->debugfs_dapm = debugfs_create_dir("dapm", parent); if (!dapm->debugfs_dapm) {