| Message ID | 557B0528.2060404@eurekelettronica.it (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e256da84a04ea31c3c215997c847609af224e8f4 |
| Headers | show |
Hello, I didn't receive any feedback about this posting... On 06/12/2015 06:13 PM, gianluca wrote: > Hello, > in attachment there is a small patch to ensure the correct register > value for MIC BIAS Voltage. diff -Nru linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c linux-4.0.5/sound/soc/codecs/sgtl5000.c --- linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c 2015-06-06 17:21:22.000000000 +0200 +++ linux-4.0.5/sound/soc/codecs/sgtl5000.c 2015-06-12 18:09:38.363381087 +0200 @@ -1339,8 +1339,8 @@ sgtl5000->micbias_resistor << SGTL5000_BIAS_R_SHIFT); snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL, - SGTL5000_BIAS_R_MASK, - sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT); + SGTL5000_BIAS_VOLT_MASK, + sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT); /* * disable DAP * TODO:
Hi Gianluca On Wed, Jun 17, 2015 at 8:20 AM, gianluca <gianlucarenzi@eurekelettronica.it> wrote: > Hello, > I didn't receive any feedback about this posting... > > On 06/12/2015 06:13 PM, gianluca wrote: >> >> Hello, >> in attachment there is a small patch to ensure the correct register >> value for MIC BIAS Voltage. > > > diff -Nru linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c > linux-4.0.5/sound/soc/codecs/sgtl5000.c > --- linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c 2015-06-06 > 17:21:22.000000000 +0200 > +++ linux-4.0.5/sound/soc/codecs/sgtl5000.c 2015-06-12 > 18:09:38.363381087 +0200 > @@ -1339,8 +1339,8 @@ > sgtl5000->micbias_resistor << > SGTL5000_BIAS_R_SHIFT); > > snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL, > - SGTL5000_BIAS_R_MASK, > - sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT); > + SGTL5000_BIAS_VOLT_MASK, > + sgtl5000->micbias_voltage << > SGTL5000_BIAS_VOLT_SHIFT); > /* According to what I see look fine. Fabio will comment on it. You should adjust the subject like: ASoC: sgtl5000: <description here> Michael > * disable DAP > * TODO: > >
Hi Gianluca, On Wed, Jun 17, 2015 at 4:20 AM, gianluca <gianlucarenzi@eurekelettronica.it> wrote: > Hello, > I didn't receive any feedback about this posting... Thanks for your patch. Please don't post patches as attachments. Better send them with 'git send-email'. Documentation/SubmittingPatches has the information you need. You also need to provide a commit log, proper Subject and your Signed-off-by. Then Cc the maintainer: ./scripts/get_maintainer.pl <yourpatch> can help you listing the appropriate folks. Regards, Fabio Estevam
Hi On Jun 17, 2015 3:03 PM, "Fabio Estevam" <festevam@gmail.com> wrote: > > Hi Gianluca, > > On Wed, Jun 17, 2015 at 4:20 AM, gianluca > <gianlucarenzi@eurekelettronica.it> wrote: > > Hello, > > I didn't receive any feedback about this posting... > > Thanks for your patch. > > Please don't post patches as attachments. Better send them with 'git > send-email'. > Documentation/SubmittingPatches has the information you need. > > You also need to provide a commit log, proper Subject and your Signed-off-by. > > Then Cc the maintainer: ./scripts/get_maintainer.pl <yourpatch> can > help you listing the appropriate folks. > Already inform him about rule ;) He should send up a new one Michael > Regards, > > Fabio Estevam > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
diff -Nru linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c linux-4.0.5/sound/soc/codecs/sgtl5000.c --- linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c 2015-06-06 17:21:22.000000000 +0200 +++ linux-4.0.5/sound/soc/codecs/sgtl5000.c 2015-06-12 18:09:38.363381087 +0200 @@ -1339,8 +1339,8 @@ sgtl5000->micbias_resistor << SGTL5000_BIAS_R_SHIFT); snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL, - SGTL5000_BIAS_R_MASK, - sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT); + SGTL5000_BIAS_VOLT_MASK, + sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT); /* * disable DAP * TODO: