From patchwork Mon Sep 7 11:54:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lars-Peter Clausen X-Patchwork-Id: 7134071 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E1077BEEC1 for ; Mon, 7 Sep 2015 12:02:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1F3BF20674 for ; Mon, 7 Sep 2015 12:02:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 43A182064F for ; Mon, 7 Sep 2015 12:01:58 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 8F920260524; Mon, 7 Sep 2015 14:01:56 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id A3300260505; Mon, 7 Sep 2015 14:01:49 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 571DE260505; Mon, 7 Sep 2015 14:01:47 +0200 (CEST) Received: from smtp-out-020.synserver.de (smtp-out-026.synserver.de [212.40.185.26]) by alsa0.perex.cz (Postfix) with ESMTP id 69EF3260506 for ; Mon, 7 Sep 2015 14:01:37 +0200 (CEST) Received: (qmail 28691 invoked by uid 0); 7 Sep 2015 11:54:28 -0000 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 28639 Received: from pd9e2fb38.dip0.t-ipconnect.de (HELO ?192.168.2.127?) [217.226.251.56] by 217.119.54.87 with AES128-SHA encrypted SMTP; 7 Sep 2015 11:54:27 -0000 Message-ID: <55ED7AF2.1050800@metafoo.de> Date: Mon, 07 Sep 2015 13:54:26 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Manuel Lauss , alsa-devel@alsa-project.org References: In-Reply-To: Subject: Re: [alsa-devel] ASoC: please revert "ASoC: db1200: Use static DAI format setup" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On 09/06/2015 07:32 PM, Manuel Lauss wrote: > Hi Lars, > > commit b4508d0f95fa4aaed889549e31391641d675d4bb > ("ASoC: db1200: Use static DAI format setup") breaks I2S in that the > set_dai_fmt() callbacks of neither the codec (wm8731) nor the I2S block > (psc-i2s) are called. > > Please revert this change or fix it up so that the set_dai_fmt() callbacks > are at least called once. (This was broken since 4.0, but I just now got > around to test linux on the hardware again). Hi, Can you check whether the attached patch fixes it? - Lars diff --git a/sound/soc/au1x/db1200.c b/sound/soc/au1x/db1200.c index 58c3164..8c907eb 100644 --- a/sound/soc/au1x/db1200.c +++ b/sound/soc/au1x/db1200.c @@ -129,6 +129,8 @@ static struct snd_soc_dai_link db1300_i2s_dai = { .cpu_dai_name = "au1xpsc_i2s.2", .platform_name = "au1xpsc-pcm.2", .codec_name = "wm8731.0-001b", + .dai_fmt = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_NB_NF | + SND_SOC_DAIFMT_CBM_CFM, .ops = &db1200_i2s_wm8731_ops, }; @@ -146,6 +148,8 @@ static struct snd_soc_dai_link db1550_i2s_dai = { .cpu_dai_name = "au1xpsc_i2s.3", .platform_name = "au1xpsc-pcm.3", .codec_name = "wm8731.0-001b", + .dai_fmt = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_NB_NF | + SND_SOC_DAIFMT_CBM_CFM, .ops = &db1200_i2s_wm8731_ops, };