From patchwork Mon Mar 26 18:32:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kirill Marinushkin X-Patchwork-Id: 10308495 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8E2BE60386 for ; Mon, 26 Mar 2018 18:31:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77FBA29581 for ; Mon, 26 Mar 2018 18:31:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6CD2029584; Mon, 26 Mar 2018 18:31:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 765B729581 for ; Mon, 26 Mar 2018 18:31:45 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1D0EA266FA1; Mon, 26 Mar 2018 20:31:44 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 91DC826709D; Mon, 26 Mar 2018 20:31:41 +0200 (CEST) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by alsa0.perex.cz (Postfix) with ESMTP id BE7C9266E4B for ; Mon, 26 Mar 2018 20:31:39 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id v21so17278568wmc.1 for ; Mon, 26 Mar 2018 11:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=gm/wm2/m95jw3RpTXKHTOtkEUMihk0ZxqIu5B6dirHM=; b=OoJZtHQ3/6ZdSygekIgsII35yTE8suS6N/+A8E/nm1o5XUg9br0+X+EFO40gDgVUzp enX150w33mz0LO588Qqzi/PD8CcaXURFQV4G5/nE/2E3aaANC22DBGN+PwfHPbVgqbK8 ZTEpaW0rNJRuWazId7urGefHS+x7+ZyBT7Dh2UwordL3W82x35LVNBKUiGc5IgdZzQw1 FszoM9+zJFGbnZ8Kw8Zr5AOh/pF63lQ9vTi1rMZZCqxZLhA9V89fKeRWtjvFRuXtvCJa KT6IiLzoFJRpdiemVugB78vGMqzN7+4L3aufW9ozQqIlrligT9mw+LPbdJVbFsc2Ub1/ nXmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=gm/wm2/m95jw3RpTXKHTOtkEUMihk0ZxqIu5B6dirHM=; b=lGqrmJWm8gDhNtrYVQhFFZQXbeDB8Kf6ATvx21v19VgMjzFBmbtazsPxNK/5Y/jK7+ feNj+NY/b1QdDME84aCvp8G1rFxvqfTZJrn+xHDR8p5wkYDsmNgQlNoPD8OS5zuxt/Y8 K9+myOe4gm/K1UD4tsKZRzml5+lnBEOJto7NfdKUTW6AkUueosfCgQfu+y0mZ2pqaeW2 OpHuoFTofr4ZpMdBfqIRE5KTPp6fOHKstg+ACbIyXnD7FMPIOiF+ocvCU5SgEknQgNJu IzIf+YEm2kDNt594rFWiVjKXXuc/zEp1ieNYnuusMW4kJ/t27JuY3W9DyBfv5H6PDHu2 mwcQ== X-Gm-Message-State: AElRT7EgKQRXrqD4O916GDKjLUmM1IF4cvAHvoZBmTIR6qEjsT4z7B/q JbepnH11YbC2i1hkUqlSQGXb83DI X-Google-Smtp-Source: AIpwx4/Gptcp2aHZlYzAcleZtnPln0iFJQQANVUuOYQLZNSZcHaxyPM1yngQu3VHGKzxly/24ZULPw== X-Received: by 10.80.243.18 with SMTP id p18mr400947edm.235.1522089098511; Mon, 26 Mar 2018 11:31:38 -0700 (PDT) Received: from [192.168.1.3] (x4dba8740.dyn.telefonica.de. [77.186.135.64]) by smtp.gmail.com with ESMTPSA id e24sm10866410edc.47.2018.03.26.11.31.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 11:31:37 -0700 (PDT) To: Takashi Iwai References: <20180326051144.16672-1-k.marinushkin@gmail.com> From: Kirill Marinushkin Message-ID: <58f2b5d7-35ce-7233-2dbf-d4e1f0b1f617@gmail.com> Date: Mon, 26 Mar 2018 20:32:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [RFC, alsa-utils] RFC: alsamixer: Improve description of playback switches X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On 03/26/18 09:38, Takashi Iwai wrote: > On Mon, 26 Mar 2018 07:11:44 +0200, > Kirill Marinushkin wrote: >> Currently, all playback switches are described as mute. It is shown as: >> >> [OO] == sound is on (left and right channels) >> [MM] == sound is muted (left and right channels) >> >> But cards can have different kinds of switch controls, not only mute. At >> least usb-audio provides boolean controls as playback switches for: >> >> * clock source validity (read only switch) >> * processing features on/off (rw switch) >> * potentially other similar use-cases >> >> It becames confusing, because it is shown as: >> >> [OO] == clock source is valid >> [MM] == clock source is invalid >> >> [OO] == processing feature is on >> [MM] == processing feature is off >> >> And from the help, it is not clear how to toggle such switches. >> >> In this RFC, I suggest to show switches more generic: >> >> [yy] == sound on / clock source is valid / processing feature is on >> [nn] == sound muted / clock source is invalid / processing feature is off > I don't think it's better solution, sorry. The current symbol isn't > the best of the best, I admit. But yy/nn isn't better from the > visibility POV, and what's worse is the sudden change of user > experience on such a long-living application. Also, you can't expect > every user understanding English. You are right. Change of symbols will complicate the experience. I agree that we better keep the current ones. > > If the problem is about the mismatch of mute/non-mute symbol against > the switch state, we may blacklist / whitelist the element names. > At easiest, we can keep using mute symbol for "xxx Playback Switch". > This is very likely a mute control. The rest is neutral, so something > more generic symbol can be used for on/off instead of 'M'. I faced 2 problems: * the clock source validity was displayed as [O]. I thought it is a zero, which is the opposite from the real state * I couldn't find how to turn the processing feature on. The help doesn't say anything about it I agree that we better keep the symbol unchanged. But in the help we need to clarify the use-case. Below is an alternative way to make it clear. What do you think about this? > thanks, > > Takashi --- a/alsamixer/mixer_widget.c +++ b/alsamixer/mixer_widget.c @@ -210,9 +210,11 @@ static void show_help(void)                 _("Z X C      Decrease left/both/right volumes"),                 _("B          Balance left and right volumes"),                 "", -               _("M          Toggle mute"), +               _("M          Toggle mute/switch"),                 /* TRANSLATORS: or , . */ -               _("< >        Toggle left/right mute"), +               _("< >        Toggle left/right mute/switch"), +               _("           [O] == playback on / switch on"), +               _("           [M] == playback muted / switch off"),                 "",                 _("Space      Toggle capture"),                 /* TRANSLATORS: or Insert Delete */