From patchwork Wed Oct 13 13:49:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 12555919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF0F4C433EF for ; Wed, 13 Oct 2021 13:50:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5CB66109E for ; Wed, 13 Oct 2021 13:50:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E5CB66109E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7491882C; Wed, 13 Oct 2021 15:49:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7491882C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1634133049; bh=nRPDRhezXgbjNUwR2KKDqwjOts6DKygUWLtp48OcxEs=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=nQXUNLXS/2kukS+SWKCZsOWRVdDUm0ONTcn/3BIVGd0tOhg7+orHQGpRiHC4nxPko U5z1QTbAuou/gZUCEkpoJyXU+dw5mgqwjtpk9zfFiSjL7xb/Q1Y5dMp01FmqOElxMZ a0P7OAHVlg/N5pJIc227ME8HQyb6jkW593AvgG48= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id ECABDF8025B; Wed, 13 Oct 2021 15:49:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6F254F80269; Wed, 13 Oct 2021 15:49:56 +0200 (CEST) Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 67EA1F800C0 for ; Wed, 13 Oct 2021 15:49:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 67EA1F800C0 Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:9c93:91ff:d58:ecfb]) by baptiste.telenet-ops.be with bizsmtp id 5Rpk2600J0KW32a01RpkbH; Wed, 13 Oct 2021 15:49:46 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1maedc-004bZh-7n; Wed, 13 Oct 2021 15:49:44 +0200 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from ) id 1maedb-0035bZ-Nx; Wed, 13 Oct 2021 15:49:43 +0200 From: Geert Uytterhoeven To: Nicolas Frattaroli , Liam Girdwood , Mark Brown , Rob Herring , Heiko Stuebner Subject: [PATCH] ASoC: dt-bindings: rockchip: i2s-tdm: Fix rockchip, i2s-[rt]x-route Date: Wed, 13 Oct 2021 15:49:42 +0200 Message-Id: <606809e10db02f92b1e7f90c491cc72dd8e16f79.1634132907.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Cc: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" make dt_binding_check: Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml: properties:rockchip,i2s-rx-route: {'required': ['maxItems']} is not allowed for {'$ref': '/schemas/types.yaml#/definitions/uint32-array', 'description': 'Defines the mapping of I2S RX sdis to I2S data bus lines. By default, they are mapped one-to-one. rockchip,i2s-rx-route = <3> would mean sdi3 is receiving from data0.', 'maxItems': 4, 'items': [{'enum': [0, 1, 2, 3]}]} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml: properties:rockchip,i2s-tx-route: {'required': ['maxItems']} is not allowed for {'$ref': '/schemas/types.yaml#/definitions/uint32-array', 'description': 'Defines the mapping of I2S TX sdos to I2S data bus lines. By default, they are mapped one-to-one. rockchip,i2s-tx-route = <3> would mean sdo3 is sending to data0.', 'maxItems': 4, 'items': [{'enum': [0, 1, 2, 3]}]} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# Drop the "-" from the enums to fix this. Fixes: 510f1c133aedcf69 ("ASoC: dt-bindings: rockchip: add i2s-tdm bindings") Signed-off-by: Geert Uytterhoeven --- v4/v5 differed slightly from what Rob suggested in his review of v3 https://lore.kernel.org/all/YS6kHkeOKCJMOOIf@robh.at.kernel.org/ --- Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml index dce8b4136ec6db4e..ce3e18b50230dc9b 100644 --- a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml +++ b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml @@ -112,7 +112,7 @@ properties: rockchip,i2s-rx-route = <3> would mean sdi3 is receiving from data0. maxItems: 4 items: - - enum: [0, 1, 2, 3] + enum: [0, 1, 2, 3] rockchip,i2s-tx-route: $ref: /schemas/types.yaml#/definitions/uint32-array @@ -122,7 +122,7 @@ properties: rockchip,i2s-tx-route = <3> would mean sdo3 is sending to data0. maxItems: 4 items: - - enum: [0, 1, 2, 3] + enum: [0, 1, 2, 3] rockchip,io-multiplex: description: