[v2] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist

Commit Message

Daniel Abrecht Jan. 17, 2024, 1:44 p.m. UTC

In U-Boot, the default for DMI vendor / product if not set is "Unknown" 
and "Unknown Product".
See 
https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272

This patch adds them to the dmi_blacklist.

Signed-off-by: Daniel Abrecht <[e-mail]>
Acked-by: Jaroslav Kysela <[e-mail]>
---
  sound/soc/soc-core.c | 2 ++
  1 file changed, 2 insertions(+)

Comments

Mark Brown Jan. 22, 2024, 12:05 a.m. UTC | #1

On Wed, Jan 17, 2024 at 02:44:43PM +0100, Daniel Abrecht wrote:
> In U-Boot, the default for DMI vendor / product if not set is "Unknown" and
> "Unknown Product".

This doesn't apply against current code, please check and resend.

Daniel Abrecht Jan. 22, 2024, 9:46 a.m. UTC | #2

I think this time it should work. It's surprisingly difficult to get roundcube to not alter plain text messages. Sorry about that.

Mark Brown Jan. 22, 2024, 3:30 p.m. UTC | #3

On Wed, Jan 17, 2024 at 02:44:43PM +0100, Daniel Abrecht wrote:
> In U-Boot, the default for DMI vendor / product if not set is "Unknown" and
> "Unknown Product".
> See https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272

This is still corrupted according to git am unfortunately.  I can't
immediately spot the issue.

Daniel Abrecht Jan. 22, 2024, 5:53 p.m. UTC | #4

Am 2024-01-22 16:30, schrieb Mark Brown:
> On Wed, Jan 17, 2024 at 02:44:43PM +0100, Daniel Abrecht wrote:
>> In U-Boot, the default for DMI vendor / product if not set is "Unknown" and
>> "Unknown Product".
>> See https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272
> 
> This is still corrupted according to git am unfortunately.  I can't
> immediately spot the issue.

The v3 I sent applies just fine with "git am" as far as I can tell. I just tested it again with the mail form the list.
I think the v3 patch is fine, but this time, the v3 message ended up with the same message ID as the v2 message.
Because of this, some mail clients may get confused, and the threading in mail clients is going to be broken.

Patch

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index f8524b5bfb33..aa1a31abbe3a 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1804,6 +1804,8 @@  static const char * const dmi_blacklist[] = {
  	"Board Manufacturer",
  	"Board Vendor Name",
  	"Board Product Name",
+	"Unknown",
+	"Unknown Product",
  	NULL,	/* terminator */
  };