From patchwork Tue Nov 6 01:04:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 10669523 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 612011709 for ; Tue, 6 Nov 2018 02:22:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D4002A1E7 for ; Tue, 6 Nov 2018 02:22:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 40D9C2A1FE; Tue, 6 Nov 2018 02:22:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D13B02A1FD for ; Tue, 6 Nov 2018 02:22:17 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 0F3B32679B1; Tue, 6 Nov 2018 02:05:15 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B4DC32679BF; Tue, 6 Nov 2018 02:05:12 +0100 (CET) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by alsa0.perex.cz (Postfix) with ESMTP id 56ADB267930 for ; Tue, 6 Nov 2018 02:05:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:Subject:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yD2Kn6zCqGM9XM2r+MV3pzy6/nGXxCSzxHkKfnLJIKQ=; b=uu2hpiZYb2hrGizUF0EIScHv2Q c7ol08m63g1QbeOcnPMrL5Fjj9MWF8wPNi3IRPNx6eeeaNJtvQ+PwiNzqFq2jhdPAK48bdtwj6Ub2 bHAfij7ifldYQ+W1vyQu8zU//0ZmyG1X/XZ72h+bU7wePdtBfReq4oudEkxRm6hbLVV9OMR5UTdJZ NUyMAdKfGXw4cZ7ZtEDyQ9jdGOJKBE+HayUFOX9BXX//0JhlpcMSvZbCOV2Dp+fkw8VrKKN1c98Sy 12x6VHQPXxv+q7Yo0+QCHHjXwl/no0FU9dq1TSMYcMowucBZ/Pc6r7nM4pUXcLHgtBIttHUhphvLk vDtF/ZLw==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=dragon.dunlab) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gJpnZ-0002PW-BA; Tue, 06 Nov 2018 01:04:53 +0000 From: Randy Dunlap To: Geert Uytterhoeven , Linux Kernel Mailing List References: <20181105220559.27458-1-geert@linux-m68k.org> Message-ID: <80f2f98b-9ab1-2a1c-0962-63e3be1dd742@infradead.org> Date: Mon, 5 Nov 2018 17:04:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: linux-s390 , ALSA Development Mailing List , linuxppc-dev Subject: [alsa-devel] Build regressions/improvements in v4.20-rc1 (sound/pci/hda/patch_ca0132.c) X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On 11/5/18 2:12 PM, Geert Uytterhoeven wrote: > On Mon, Nov 5, 2018 at 11:07 PM Geert Uytterhoeven wrote: >> Below is the list of build error/warning regressions/improvements in >> v4.20-rc1[1] compared to v4.19[2]. >> >> Summarized: >> - build errors: +3/-0 >> - build warnings: +449/-2712 >> >> Happy fixing! ;-) >> >> Thanks to the linux-next team for providing the build service. >> >> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/651022382c7f8da46cb4872a545ee1da6d097d2a/ (all 240 configs) >> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/84df9525b0c27f3ebc2ebb1864fa62a97fdedb7d/ (all 240 configs) >> >> >> *** ERRORS *** >> >> + /kisskb/src/sound/pci/hda/patch_ca0132.c: error: implicit declaration of function 'pci_iomap' [-Werror=implicit-function-declaration]: => 8799:3 > > sh4-all{mod,yes}config > > Looks like d9b84a15892c0233 ("ALSA: hda: Fix implicit definition of > pci_iomap() on SH") > is not sufficient? Different problem. This is about "select": config SND_SOC_ALL_CODECS tristate "Build all ASoC CODEC drivers" That enables (sets): select SND_SOC_HDAC_HDA which selects SND_HDA even though CONFIG_PCI is not enabled. After SND_HDA is selected (above), the Kconfig symbols in sound/pci/hda/Kconfig are available for enabling, so SND_HDA_CODEC_CA0132 is enabled but will not build. One simple solution (but possibly too naive) is: Reported-by: Geert Uytterhoeven Signed-off-by: Takashi Iwai --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- lnx-420-rc1.orig/sound/soc/codecs/Kconfig +++ lnx-420-rc1/sound/soc/codecs/Kconfig @@ -82,7 +82,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_ES7241 select SND_SOC_GTM601 select SND_SOC_HDAC_HDMI - select SND_SOC_HDAC_HDA + select SND_SOC_HDAC_HDA if PCI select SND_SOC_ICS43432 select SND_SOC_INNO_RK3036 select SND_SOC_ISABELLE if I2C