| Message ID | 86590.1474409693@turing-police.cc.vt.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sep 21 2016 07:14, Valdis Kletnieks wrote: > ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP > > ERROR: "snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined! > scripts/Makefile.modpost:91: recipe for target '__modpost' failed > make[1]: *** [__modpost] Error 1 > > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> As a nitpicking, I think it better to change the subject line with a prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our fashion. > diff --git a/sound/usb/line6/Kconfig b/sound/usb/line6/Kconfig > index 8ffcf48097d9..39b400392d71 100644 > --- a/sound/usb/line6/Kconfig > +++ b/sound/usb/line6/Kconfig > @@ -2,6 +2,7 @@ config SND_USB_LINE6 > tristate > select SND_RAWMIDI > select SND_PCM > + select SND_HWDEP > > config SND_USB_POD > tristate "Line 6 POD USB support" Thanks Takashi Sakamoto
On Wed, 21 Sep 2016 03:56:05 +0200, Takashi Sakamoto wrote: > > On Sep 21 2016 07:14, Valdis Kletnieks wrote: > > ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP > > > > ERROR: "snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined! > > scripts/Makefile.modpost:91: recipe for target '__modpost' failed > > make[1]: *** [__modpost] Error 1 > > > > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> > > Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> > > As a nitpicking, I think it better to change the subject line with a > prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our > fashion. Yes, I modified the subject line and added fixes tag. thanks, Takashi > > diff --git a/sound/usb/line6/Kconfig b/sound/usb/line6/Kconfig > > index 8ffcf48097d9..39b400392d71 100644 > > --- a/sound/usb/line6/Kconfig > > +++ b/sound/usb/line6/Kconfig > > @@ -2,6 +2,7 @@ config SND_USB_LINE6 > > tristate > > select SND_RAWMIDI > > select SND_PCM > > + select SND_HWDEP > > > > config SND_USB_POD > > tristate "Line 6 POD USB support" > > > Thanks > > Takashi Sakamoto >
diff --git a/sound/usb/line6/Kconfig b/sound/usb/line6/Kconfig index 8ffcf48097d9..39b400392d71 100644 --- a/sound/usb/line6/Kconfig +++ b/sound/usb/line6/Kconfig @@ -2,6 +2,7 @@ config SND_USB_LINE6 tristate select SND_RAWMIDI select SND_PCM + select SND_HWDEP config SND_USB_POD tristate "Line 6 POD USB support"
ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP ERROR: "snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>