From patchwork Thu Nov 26 11:13:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 7705951 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id EBF339F443 for ; Thu, 26 Nov 2015 11:14:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 27C07207BA for ; Thu, 26 Nov 2015 11:14:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id EFBE7207AA for ; Thu, 26 Nov 2015 11:14:42 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 046E7261B01; Thu, 26 Nov 2015 12:14:41 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAD_ENC_HEADER,BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 7254E261A0A; Thu, 26 Nov 2015 12:14:21 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id A5AAA261A0A; Thu, 26 Nov 2015 12:14:20 +0100 (CET) Received: from relmlie2.idc.renesas.com (relmlor3.renesas.com [210.160.252.173]) by alsa0.perex.cz (Postfix) with ESMTP id 40495261A90 for ; Thu, 26 Nov 2015 12:13:46 +0100 (CET) Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie2.idc.renesas.com with ESMTP; 26 Nov 2015 20:13:42 +0900 Received: from relmlac1.idc.renesas.com (relmlac1.idc.renesas.com [10.200.69.21]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 7C5304DEE8; Thu, 26 Nov 2015 20:13:42 +0900 (JST) Received: by relmlac1.idc.renesas.com (Postfix, from userid 0) id 7ACA58002E; Thu, 26 Nov 2015 20:13:42 +0900 (JST) Received: from relmlac1.idc.renesas.com (localhost [127.0.0.1]) by relmlac1.idc.renesas.com (Postfix) with ESMTP id 74A138002D; Thu, 26 Nov 2015 20:13:42 +0900 (JST) Received: from relmlii2.idc.renesas.com [10.200.68.66] by relmlac1.idc.renesas.com with ESMTP id WAJ19146; Thu, 26 Nov 2015 20:13:42 +0900 X-IronPort-AV: E=Sophos;i="5.20,346,1444662000"; d="scan'";a="200598006" Received: from mail-sg2apc01lp0247.outbound.protection.outlook.com (HELO APC01-SG2-obe.outbound.protection.outlook.com) ([65.55.88.247]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA; 26 Nov 2015 20:13:41 +0900 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by HK2PR06MB1009.apcprd06.prod.outlook.com (10.161.183.28) with Microsoft SMTP Server (TLS) id 15.1.331.20; Thu, 26 Nov 2015 11:13:40 +0000 Message-ID: <87610pc8xc.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Thu, 26 Nov 2015 11:13:40 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: OS2PR01CA0015.jpnprd01.prod.outlook.com (25.161.74.153) To HK2PR06MB1009.apcprd06.prod.outlook.com (25.161.183.28) X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB1009; 2:mADiBjXuUNjP135J54qwcKSCcKXrqDHQ/3QEuESOyAoVdZkVHEr1WnvOXHddpLsnFfyJHY/fXfX4KHAlqwFboq9fDP8oOx2EH/sKgZYk8shsEepN+3kW94Xk7BGN7Fr4VFo9EJP4k6ifbtfJSESJtg==; 3:IiycvEwl1zhFdfxN95O5oSo9XpiZrj0ckJAJRetMAzDU3QTRzfB0dyC7PO3YIUfXwx+lNHVXByNbWszgDUh3nSMiMKmDn8nxFWlYLnQQvp7kVahUAFGXQ+sCDdf3dI8+; 25:AYK/RdVj549XrfJRYDun7do17ONaWQ27BFI659Iyo/ZHiR3jjD+2ftMJq8v4IAaA7NJbzy0Qt11p6Z6s1ktYAtTQo+3sMGjJA+V5TFnd2mucfbpMWEeOunatXwnHDla7tlSuu5en2Bo8n6kBhJbZDBFcj7UjFybaWcg/cXR7sjuapLieztVVf0pszfEfh7V4ldHYmstLSt/3KZegomlQ7GJqaTdUoPPoHdL1nq62tLqt6Ee1RIDe7q4AXlRERfVwG0PQMTPM6EbLL75ZV+pBVQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HK2PR06MB1009; X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB1009; 20:GiwVh1qCVaQESgGe7Nv6wZRF/07sAZCXGeybpcjHQdHzckx9ihQ4pTDgBnJGySCCsL+dac5+0C6Gfr4zWwFFENTKeFxbdpb/yO68rHs7HHus010k/nEsQbH+1+heRkZz+i8TaXGqoMKT4OuMzW3M9LKXTN36ewGXO5kytkxrF/eae4VfR/JfgOyzrrJlpF15R8Sc/yrvNv6g5z9Dagpme3VcrQGANt2+6SD6RqoCELLjJ645g7l7AloASRxudi2eaeZ4oLS+bB8MLan8gYLH6mEXSpxdLjVpKYbBEzoxI+xDncjGNEIn+priUzmDOlPMCm708flVs5j7dS+TWr6lmw8CTEIAcgSvP5xS1Jsh5gUt5vs6M+8wMVRWYlu+TlYaj11uz5ULg2Xhxl7NMnokvwSnqQghOBzywPxszJAQkaz937bHK4Si7Dgxqh4pKKOLMDleZkgK9d1axPhfaxHbv0X3ljpfDRVnxUBwA9fc5H2f74DR0v53LTpm82JrCwwP; 4:EWi/PMxkzfns4Y7h934DREP6BRj4UHRZRy+jdTwpSX/ryrsT3PxVdw++0cSKVRB6ofzm0OTzfdzHebtINyr54NvoylgSGsu5uXCYla8zpr9T2rKZegbmL4dFN6x77q5bRVA678bVxR1PqNRpIAcmsG/JqxWrOq9M1gSFshM+/IvHhjyfKfbEQ8gNbdpFU43adCM8kBWsebs5/56PRgn4JXLaqENBDMiV8Piwndg8ECNAIhdD8ymK8jAguIVBOb+84kHFbAJ8A720HOVx56Yyp8DWZCBC1E98ERFyC5COkrPf7HTp7NYEYIEER0bynlV7k80plGITDJ/X3Lb+NBhdF+vc3XnhbUcn1pwlnPF1rnhc8rNgsj2ftmUi5AS5ibpIlD1yh96Lru1A4GvnBDnIj1w0cRzAYlqEeydYwpQkz7pNJuNtKk1/ZSh3zpnKP+Zv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85106069007906); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(10201501046)(3002001); SRVR:HK2PR06MB1009; BCL:0; PCL:0; RULEID:; SRVR:HK2PR06MB1009; X-Forefront-PRVS: 0772E5DAD5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(189002)(199003)(77096005)(53416004)(42186005)(105586002)(69596002)(19580405001)(33646002)(5001960100002)(19580395003)(5004730100002)(46406003)(189998001)(110136002)(6116002)(106356001)(3846002)(23726003)(229853001)(586003)(87976001)(92566002)(86362001)(83506001)(1096002)(66066001)(5008740100001)(54356999)(47776003)(101416001)(40100003)(36756003)(122386002)(4001350100001)(97736004)(81156007)(50466002)(50986999); DIR:OUT; SFP:1102; SCL:1; SRVR:HK2PR06MB1009; H:morimoto-PC.renesas.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HK2PR06MB1009; 23:TFMAIsfBDuwXNOOCcvTpzBmAyofP8LPXIYJwOwJx5?= =?us-ascii?Q?Lp4sXa/CIl5MkzM7JhsqFpIGJwNxQx5YKYst6gfEGTPzuqwytfUzoueo9v0X?= =?us-ascii?Q?z7xDZ0SrftLVXbzed/1vYbdpY4GXel7v5o92f04twQRkQ2XfL3QBzuIo6XEe?= =?us-ascii?Q?YsxmrQeanVcfTLFdNkPPeypNOLxNpzAfD0gN1UKbVTnV4yRT/LQGUsQh2z6D?= =?us-ascii?Q?lt7MgWYMObeQ8+ut7rvRuWx8dfT0Us6SYw+pgC9x6W5HPaqZ4hvQXe8lAkFp?= =?us-ascii?Q?z9ujyNZzc6F7wKjjSFNvPMhkc0Dv8GAu1wi5ZlCW/DNsLUL9n5O/1xp8/oL3?= =?us-ascii?Q?19KuDlTDR64gpPt98XQHocRiXTjRZx86HsHcZ6hVVZO/B+3kodz0B5lDkaW6?= =?us-ascii?Q?NOcH9hx0p/EJNnNX7r2F6E3B6Pb4LP1Z/o1GySlK0fP/DFH02jTUgk4F3gpj?= =?us-ascii?Q?o90rVMI+7nTsC+4Xy6dk97iBmkcC3TiLsRqt/ShLFad0jIYrYMw68fBinAIL?= =?us-ascii?Q?iP1igQgoH+OQ5rVtpZLE+gPo1rZohTF9kN5i048qG1BuLR/AjEz/4ElNFDgA?= =?us-ascii?Q?9ZquuAS7+I2kabZG0RiJfxIfu6uYpMITmTOSnVxCAoyrww4LYozbecy7BQft?= =?us-ascii?Q?Gqq3CQ7nWXjOUnz8zfH3IzpRKWwAZNUCo9ZwOM2wEVrENbT9FeFOP4y+xiuq?= =?us-ascii?Q?nTWnzFY57v1z6wGBRJWIn4AGKbTjzUMaLRUY5DUiockQAtINNCdlD1dydphR?= =?us-ascii?Q?HVDNz3ydBVCCtldAkP+Fqu5jffa+DtCUXsogTPmqHfpdsTkoXaLPm1eZMkc0?= =?us-ascii?Q?sawUQ5g+4bfRh3APHjhUFbBtOa8q0JlszFqjyxMPujLy7/BUTGe0nEVRjmnc?= =?us-ascii?Q?9+IVsRkc0QKXu28zkhmgRWILD1gwOZgfnaEVdinHZPA+oH9tDMGG4slTunKK?= =?us-ascii?Q?DY5hPt1JhdTINAzfGFHJja9bHRSNukKcn4Ut28bJkHZ5J7bmYWsT9am2Jvip?= =?us-ascii?Q?jGDFKbLXUZZr/1RssylnquRuf/k6fwnjIMhdiJ6LmtFAwESfGz0Nwj6HxG7L?= =?us-ascii?Q?9v7gso=3D?= X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB1009; 5:pYSZ9OCOvCr1rb18A7ttG6DOlw1+cP6tLf+aoXtnYI7QlBFygzOOUVGURkWf3w7H+J6Mf/mfbXDrK1VI4xKiX/QFLwXcoGsOVb945ffBRU6ATTAj/WF38WzKdvjHexei9wZq66g3QAsnYrc0mh6Zpw==; 24:D+6RBoVsqmE9Ni7aDjzYfXBfTpDAMRoWXpBqyFY5vm9kBITf7Z1/8OfM+IJAiDP97YXk7l3gTzTytv8n81s4LNwraM6nndXZRT7vmq0IHak=; 20:/Ph0hGe0Y83lRW3e/dMw43KKVEMiqFrnLlG1XbvQXs9FreMz88IZQZtoP2JEb/gjHvySwnMfaCGGJhFkcAWLsqWATOK34SaNNHL7DT2+YP+R3+RKy7qDUzxgrs7m340CVerSLFBwkR0/OVcF1gYMMMxHxd1s5K0KfOowV6roviw= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2015 11:13:40.0095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR06MB1009 Cc: Linux-ALSA , Simon , Liam Girdwood Subject: [alsa-devel] [PATCH] ASoC: rsnd: tidyup semantics of rsnd_ssi_record_error() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto rsnd_ssi_record_error() should recorde error, but it clears error too. this patch fixes up semantic of rsnd_ssi_record_error that it records error but doesn't clear error. Signed-off-by: Kuninori Morimoto --- sound/soc/sh/rcar/ssi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index dd693c0..5b97ae8 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -395,13 +395,9 @@ static u32 rsnd_ssi_record_error(struct rsnd_ssi *ssi) u32 status = rsnd_ssi_status_get(mod); /* under/over flow error */ - if (status & (UIRQ | OIRQ)) { + if (status & (UIRQ | OIRQ)) ssi->err++; - /* clear error status */ - rsnd_ssi_status_clear(mod); - } - return status; } @@ -536,6 +532,7 @@ static void __rsnd_ssi_interrupt(struct rsnd_mod *mod, rsnd_mod_name(mod), rsnd_mod_id(mod)); } + rsnd_ssi_status_clear(mod); rsnd_ssi_interrupt_out: spin_unlock(&priv->lock);