| Message ID | 87bnkk162d.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0aed11244360c24c854a263eac0293acef2abd03 |
| Headers | show |
On Tue, Feb 24, 2015 at 12:54:16AM +0000, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Current DMAEngine implementation of DT bindings can't support > DT subnode. This patch export symbols of of_dma_request_slave_channel() > for subnode DMA DT bingings. > > ex) > > rcar_sound: rcar_sound@ec500000 { > ... > rcar_sound,dvc { > dvc0: dvc@0 { > dmas = <&audma0 0xbc>; > dma-names = "tx"; > }; > dvc1: dvc@1 { > dmas = <&audma0 0xbe>; > dma-names = "tx"; > }; > }; > ... > }; > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > v2 -> v3 > > - don't remove export from of_dma.h > > drivers/dma/of-dma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c > index ca31f1b..cbd4a8a 100644 > --- a/drivers/dma/of-dma.c > +++ b/drivers/dma/of-dma.c > @@ -194,6 +194,7 @@ struct dma_chan *of_dma_request_slave_channel(struct device_node *np, > > return ERR_PTR(ret_no_channel); > } > +EXPORT_SYMBOL_GPL(of_dma_request_slave_channel); > > /** > * of_dma_simple_xlate - Simple DMA engine translation function Typically you should post whole series. Anyway, i am okay with this patch, how do you want to merge this, should i pick it up or everything goes thru ASoC tree or something else?
Hi Mark > > Current DMAEngine implementation of DT bindings can't support > > DT subnode. This patch export symbols of of_dma_request_slave_channel() > > for subnode DMA DT bingings. > > > > ex) > > > > rcar_sound: rcar_sound@ec500000 { > > ... > > rcar_sound,dvc { > > dvc0: dvc@0 { > > dmas = <&audma0 0xbc>; > > dma-names = "tx"; > > }; > > dvc1: dvc@1 { > > dmas = <&audma0 0xbe>; > > dma-names = "tx"; > > }; > > }; > > ... > > }; > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > --- (snip) > Typically you should post whole series. Anyway, i am okay with this patch, > how do you want to merge this, should i pick it up or everything goes thru > ASoC tree or something else? I don't know detail of maintenance side. Which is best ? Best regards --- Kuninori Morimoto
On Wed, Feb 25, 2015 at 12:03:03AM +0000, Kuninori Morimoto wrote: > > Hi Mark > > > > Current DMAEngine implementation of DT bindings can't support > > > DT subnode. This patch export symbols of of_dma_request_slave_channel() > > > for subnode DMA DT bingings. > > > > > > ex) > > > > > > rcar_sound: rcar_sound@ec500000 { > > > ... > > > rcar_sound,dvc { > > > dvc0: dvc@0 { > > > dmas = <&audma0 0xbc>; > > > dma-names = "tx"; > > > }; > > > dvc1: dvc@1 { > > > dmas = <&audma0 0xbe>; > > > dma-names = "tx"; > > > }; > > > }; > > > ... > > > }; > > > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > --- > (snip) > > Typically you should post whole series. Anyway, i am okay with this patch, > > how do you want to merge this, should i pick it up or everything goes thru > > ASoC tree or something else? > > I don't know detail of maintenance side. > Which is best ? I think Mark can take the whole series with my ack on this one so Acked-by: Vinod Koul <vinod.koul@intel.com> I need I will pull Marks topic into mine but I think that may not be required..
Hi Mark > > > Typically you should post whole series. Anyway, i am okay with this patch, > > > how do you want to merge this, should i pick it up or everything goes thru > > > ASoC tree or something else? > > > > I don't know detail of maintenance side. > > Which is best ? > > I think Mark can take the whole series with my ack on this one so > > Acked-by: Vinod Koul <vinod.koul@intel.com> > > I need I will pull Marks topic into mine but I think that may not be > required.. Please let me know if I need to resend these patches.
On Tue, Feb 24, 2015 at 12:54:16AM +0000, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Current DMAEngine implementation of DT bindings can't support > DT subnode. This patch export symbols of of_dma_request_slave_channel() > for subnode DMA DT bingings. Applied, thanks.
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index ca31f1b..cbd4a8a 100644 --- a/drivers/dma/of-dma.c +++ b/drivers/dma/of-dma.c @@ -194,6 +194,7 @@ struct dma_chan *of_dma_request_slave_channel(struct device_node *np, return ERR_PTR(ret_no_channel); } +EXPORT_SYMBOL_GPL(of_dma_request_slave_channel); /** * of_dma_simple_xlate - Simple DMA engine translation function