From patchwork Fri Jan 30 05:18:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 5746631 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6B452BF440 for ; Fri, 30 Jan 2015 05:19:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 94A5E2021B for ; Fri, 30 Jan 2015 05:19:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id C9D5A2025B for ; Fri, 30 Jan 2015 05:19:22 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id A6DF6260715; Fri, 30 Jan 2015 06:19:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id E80C3260677; Fri, 30 Jan 2015 06:19:12 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3752426067B; Fri, 30 Jan 2015 06:19:11 +0100 (CET) Received: from relmlie2.idc.renesas.com (relmlor3.renesas.com [210.160.252.173]) by alsa0.perex.cz (Postfix) with ESMTP id 89F5A260676 for ; Fri, 30 Jan 2015 06:19:03 +0100 (CET) Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie2.idc.renesas.com with ESMTP; 30 Jan 2015 14:19:00 +0900 Received: from relmlac1.idc.renesas.com (relmlac1.idc.renesas.com [10.200.69.21]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 434273E207; Fri, 30 Jan 2015 14:19:00 +0900 (JST) Received: by relmlac1.idc.renesas.com (Postfix, from userid 0) id 365998002E; Fri, 30 Jan 2015 14:19:00 +0900 (JST) Received: from relmlac1.idc.renesas.com (localhost [127.0.0.1]) by relmlac1.idc.renesas.com (Postfix) with ESMTP id 3104C8002D; Fri, 30 Jan 2015 14:19:00 +0900 (JST) Received: from relmlii1.idc.renesas.com [10.200.68.65] by relmlac1.idc.renesas.com with ESMTP id QAL17765; Fri, 30 Jan 2015 14:19:00 +0900 X-IronPort-AV: E=Sophos;i="5.09,490,1418050800"; d="scan'208";a="178788839" Received: from mail-sg1lp0088.outbound.protection.outlook.com (HELO APAC01-SG1-obe.outbound.protection.outlook.com) ([207.46.51.88]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA; 30 Jan 2015 14:18:58 +0900 Received: from remon.renesas.com (211.11.155.132) by HKNPR06MB162.apcprd06.prod.outlook.com (10.242.104.19) with Microsoft SMTP Server (TLS) id 15.1.65.19; Fri, 30 Jan 2015 05:18:56 +0000 Message-ID: <87d25wg804.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Lars-Peter Clausen In-Reply-To: <1421847492-8857-1-git-send-email-lars@metafoo.de> References: <1421847492-8857-1-git-send-email-lars@metafoo.de> User-Agent: Wanderlust/2.14.0 Emacs/23.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Date: Fri, 30 Jan 2015 05:18:56 +0000 X-Originating-IP: [211.11.155.132] X-ClientProxiedBy: SIXPR06CA0040.apcprd06.prod.outlook.com (25.160.171.158) To HKNPR06MB162.apcprd06.prod.outlook.com (10.242.104.19) Authentication-Results: metafoo.de; dkim=none (message not signed) header.d=none; metafoo.de; dmarc=none action=none header.from=renesas.com; X-DmarcAction-Test: None X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(3005004);SRVR:HKNPR06MB162; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004); SRVR:HKNPR06MB162; X-Forefront-PRVS: 04724A515E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(51704005)(92566002)(42186005)(54356999)(76176999)(77096005)(53416004)(47776003)(23726002)(110136001)(50986999)(40100003)(86362001)(83506001)(77156002)(62966003)(19580405001)(122386002)(46406003)(19580395003)(66066001)(2950100001)(36756003)(46102003)(87976001)(33646002)(50466002); DIR:OUT; SFP:1102; SCL:1; SRVR:HKNPR06MB162; H:remon.renesas.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:HKNPR06MB162; X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2015 05:18:56.9421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HKNPR06MB162 Cc: alsa-devel@alsa-project.org, Simon Horman , linux-sh@vger.kernel.org, Magnus Damm , Liam Girdwood , Mark Brown , linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH v2 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Lars, Simon > The DAI link format should be specified for the whole link rather than just > one component on the link. So move the format specification for the HDMI > audio link from the CPU component to the link itself. > > Since the sh-mobile-hdmi DAI driver doesn't implement the set_fmt() callback > in this case there is no functional difference between only specifying the > the format for the CPU side or for the whole link, but the later it will > allow us to remove support for just specifying the format for one component. > > Signed-off-by: Lars-Peter Clausen > --- I tested these 3 patches on armadillo800eva [PATCH v2 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format [PATCH v2 2/3] ASoC: sh: fsi: Fix clock inversion [PATCH v2 3/3] ASoC: simple-card: Remove support for setting differing DAI formats Tested-by: Kuninori Morimoto 2/3 patch changed behavior for clock inversion on FSI driver. FSI + wm8978 on armadillo800eva worked without any issues, but, I don't know how much effect it has for other board. We used this inversion flags on each board for historical reasons (copy-paste), but, almost all these were not needed (except some picky board) on FSI. Maybe Lars's 2/3 patch is correct, but, it is difficult to check/confirm for all boards. And unfortunately, Renesas don't use FSI anymore. So, I think keeping current FSI driver as-is is more safety for old boards. armadillo800eva works well with below patch (as 2/3 patch) -------------- -------------- diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c index 75de26c..36aaeb1 100644 --- a/arch/arm/mach-shmobile/board-armadillo800eva.c +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c @@ -1015,7 +1015,6 @@ static struct asoc_simple_card_info fsi_wm8978_info = { .platform = "sh_fsi2", .daifmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM, .cpu_dai = { - .fmt = SND_SOC_DAIFMT_IB_NF, .name = "fsia-dai", }, .codec_dai = {