From patchwork Mon May 29 01:03:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 13257967 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16504C7EE23 for ; Mon, 29 May 2023 01:04:55 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 22C983E8; Mon, 29 May 2023 03:04:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 22C983E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1685322293; bh=jVO+YGsbwRnAzy9jREUYpNMZuswwebg6ihl8fGfpDtQ=; h=From:To:Cc:In-Reply-To:References:Subject:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=fuyOLQlBqhw+4weQgpjQP+DlQqMn5euhZDGga+e2VqNZyAgoMkZ2yoyM6IiealoVs FuuDqjx9Fx2zl9XQEQ/LK2BdB+lu3OR5rOgx6lZ8nqXbyW/EgVRsbb/NxVxvrNtDRz tDkUvxzSsY7s0LyggJiDHqxOZnQ3ZuKnKjPZEkFs= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 60847F8057F; Mon, 29 May 2023 03:03:20 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5508BF80580; Mon, 29 May 2023 03:03:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9615AF80580; Mon, 29 May 2023 03:03:15 +0200 (CEST) Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on20717.outbound.protection.outlook.com [IPv6:2a01:111:f403:7010::717]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6BBDAF80579 for ; Mon, 29 May 2023 03:03:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6BBDAF80579 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=GzK70zXE ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ESP1F2QSCyJ1lFoCQwkiUVHDYC4pzm5p/abMx34+z39vqFROsoayCNPXOSmVbK2Qig0KwcXsSdZZMFWYvKbgoIFwWVCPj9jmQJm0w+cjtGNCJytzpgRC00Yp/t+P5hIHHEA76Oa8RVs/oL9qnYVVciLIg4RAOZvCQ9haAJl+p3o1SzcglHJIrUUY/504AaxsIVh+B1dLBGxljY4hiz93DTxZVPjFULYmGi0QehRoDsb8TY/6daz7SDzJK3Un0IYl09LXmoXc6Iea+PYvAzkRnAdwTLdeWmjEiignjosRXvkBF0kkSdp/MlF5SP6JCyq4kFriEaq7HY7x3BZ/Q0JVhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kmQ6mb3JrwoxbGRKGzZ43ikrzMM7iiARHn29Pvf66OE=; b=dKgYEmLCuDlWuqzRfRLx0nwmm6+rNugDWIX57ke5iOIIsx3d2Jeidnbm+S3RBqWX3RlwyxkGT4ckF/77M1HdT+XDl8USJHA8vNfuCCncJfCpgN1JjAP126mvFkrKjw8ouz1JfF7UDK914wKCdynUXkoOOrRblvKUVJj8B449IJddkobmti6YjkJT95evXmMfZ0Z1D7K1Evw4XUF6LmXRg/6PwU8uu4FE4KrpeM/a70060vbmiCeyJh3kqgJAct6+aFjfWf1J3rHqb7gqHueLHB1P1hQrXw9HToMz6T790MYoDmsWbh/qlfz4EyhUedZpL04c4AuJHBQ5yu4UyhwNKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kmQ6mb3JrwoxbGRKGzZ43ikrzMM7iiARHn29Pvf66OE=; b=GzK70zXEKUB85QDT7zrltUnJmea4QTPpttRC7ejc13Krlb/npJzjq4pP7RBbP9DXWHBS+WOrN8WwL+bqF60dhOGxZcBo8t1GulBNeX0ZRBPz5zWHO0ygqpFmNRtryK8fIBUKBmpAZU/Agdz85wyeFA8vI8nGvGBi78slVopmNRI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by TYCPR01MB8658.jpnprd01.prod.outlook.com (2603:1096:400:15e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Mon, 29 May 2023 01:03:06 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840%7]) with mapi id 15.20.6433.022; Mon, 29 May 2023 01:03:06 +0000 Message-ID: <87jzwslzjq.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: alsa-devel@alsa-project.org In-Reply-To: <87o7m4lzl3.wl-kuninori.morimoto.gx@renesas.com> References: <87o7m4lzl3.wl-kuninori.morimoto.gx@renesas.com> Subject: [PATCH v3 03/21] ASoC: soc-pcm.c: cleanup soc_get_playback_capture() error User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 Date: Mon, 29 May 2023 01:03:05 +0000 X-ClientProxiedBy: TYCP286CA0222.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c5::9) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|TYCPR01MB8658:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ecce9f6-59c0-4f7e-60fa-08db5fe07609 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r8zsI46HwiGfTWi1Z9STH5mOg01BWuYzUzmEIR95DbzD8dXnd8XxVdztI5mE38bla74cDWZjtDmj7uPxKHaaZtn2UNBeOddJ1JYatR9X1qdRnh/6gQ1CMiyF8xXRIjzT2wnHXM1jUYuVg8B3ZlNhkv8RDDeNaqXlkWkw9CPd0oLzQBlWDaRLQlmGtoDJpcOAa21wKO3GZlYOFCFKN6NRtLaqnnhq7h7UzUpqqSo8BKUxYARMrkZA3VItKxYwgx6SrXVf1Bmqx3fED4m/C5cd5LT2jvsmfBgPdzsDv2qtmTHMJs/jjPSU3bmCxcu9AZhNET5i2UGrJbJWtWHG6m/ojyM76S9pzFYeehz4cH2ATK7uY2WKPrxXKPkNPkemDZtlV/Nyb2uZJK1GaBdNeiKT/yMy+J/VTx4YYDywy/piWf4Pss2pcjxK/JQdTILAk9+05JiBpmsKl4anL0aX5eOflqOvPCQfRy20gqK5ygfmXkxh6/IVFigxVBMWpsXlYUDfQmiQkPhhyktXmAXP4mAJLV2gUNxoT7L5Ms0lmJbpPKkKJeK06BU1kgPa3fu1fDAY+liDNHrAH3MVnrJXZfFGPQWaGfIN7zLZRfTWeUvrba/XolD+08LeO0GpMl2JkGRd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS3PR01MB8426.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(451199021)(26005)(38350700002)(38100700002)(41300700001)(52116002)(6486002)(83380400001)(186003)(6512007)(6506007)(2616005)(478600001)(110136005)(66946007)(66556008)(66476007)(4326008)(316002)(2906002)(5660300002)(8676002)(8936002)(86362001)(36756003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-2?q?eHPq4O7X5oHAhXI6ngGlZgU?= =?iso-8859-2?q?tcNr3kYvzM8k9zhZ0d44Oa73q5zZqsrPCD0OzV3R5qRnD6vNdV42ogQSAfCz?= =?iso-8859-2?q?OOojSuJ885QK+p3hOhKVfONAkvmUM6HerMRQBweFSjI0qtb17xMekxLwlKds?= =?iso-8859-2?q?amZG9nw3ZyuNyy1JtvMzKkESV6+HMByZy/6amHZVxn4FFs0W6Q+1CNZPzHOD?= =?iso-8859-2?q?4zjLGkGIjDYZ16y3uauILq6/Fg00GRTWit/es9Cw3P5sJIADb6U7pN31MkkQ?= =?iso-8859-2?q?fzM8gRTP3BFgr2F+3WMF7E8FCFRP9KzoWthHoemKjeU/WtPkMADTeZgj9pZh?= =?iso-8859-2?q?5AWw4h/4i5WNnNvTwQrMtkm1mcNdjVMHWEBzCmECqu66yxpzaTQ1JqnnkEHY?= =?iso-8859-2?q?PT6ursYbsz9+/OBzG6GwXSkJyjHp4dqRcllVbocMc2o0k7XKALHXlBEJ7Naq?= =?iso-8859-2?q?h2l1WiqvBkV2/03ZORo4Mbc0POCyPgLYtKd8cGQ/yV8/SrUI6f6YMGl55vFf?= =?iso-8859-2?q?FXzrB4BQi4AaBwSEI8weLlDqxHH8XiB2mLFieiwRflrY25Nqit+1DdTp7OAq?= =?iso-8859-2?q?POljeCnmBzMYHIefiGxxy9ApCjB5ZMjWPu3xJib3LvWIj1n4JEtnlIvdvtqp?= =?iso-8859-2?q?Vmk6VZl7Gle2plcdq15bcVSE6ZvFdlJCDDHpsq+feDJBKzWxLfn4viNsC40X?= =?iso-8859-2?q?8hYMiWNCO7uzAF8t9qqxwxAXx/ggiFEQPi/YWNs9r5zLZNA6hYgjsljFGzAh?= =?iso-8859-2?q?15HhqBVPIFkD/HwsmI80ZCxO+wck2c1tFEORCWZFgzdoUOI+eQWj2VK2tiUK?= =?iso-8859-2?q?hbievO4prFqAbgHMm6umFLHHVa8ga8Wn426B08qvcJaol73MIC3JX4xRiJaf?= =?iso-8859-2?q?+/W13pv+onb2YZ+xeYYP+a8MV+Xv8521txnNoBt5zmZ3+d8oQCjE0ls1GY9i?= =?iso-8859-2?q?QpY9gTTtZLCBfl7K3nQWUEMzlRTa1N+J1BrVj0cEC8wZjLXP0BdCFkD0fPOz?= =?iso-8859-2?q?h4UbN8DDQJswk6sQj4iph4YmCnHR4Mf1TLLbx/VZbGTGnjMHYQkFwuE44HRQ?= =?iso-8859-2?q?HhdEBCQD9C0wZfz6s2vmvnA9SMZbu+JxUaOI8eN0agxR4p5b0Wwah2tsBnQV?= =?iso-8859-2?q?gA3lYbbUTBTPPcHYettVxoe2Ty6in+KRuGgG/FZD5pV/92liEuZH9SDyhRY9?= =?iso-8859-2?q?Y2N6qr9kuhXW8dfrDANt/toLFFg1Ysm6zcnEOjgszZYlYP3fncKBCVkl9WaR?= =?iso-8859-2?q?JJrKegH9N9agh1XWyet9sHjXdmXgW4WEur5JIow6cwP9g2lhsceARLtHH4OA?= =?iso-8859-2?q?XC+1IiFIS3duODuvqT+/9ifpMHYJJ8llHJvs7D6UGiFz801Fn4irhC7dRlCG?= =?iso-8859-2?q?kWCfPZcNi2ZbZq2etBTenYsG1aS2aJYcrilQtqtd7yp1NFv+bfvpqmcgkDAl?= =?iso-8859-2?q?o1E2ef+/Wy0lOOA+zckSvqnGiNO2mtyjujsocOvc5JNxJEdMTjCoMGW1sWrb?= =?iso-8859-2?q?x0a7TLH+XzTmdBSx2ed+sinwX/33ppQwe2ZFGSTPEvrL65Vk0wV/ceBOb7t5?= =?iso-8859-2?q?QQw3A7I3oTLKPU6HWyDqDAxyizrVeFGXO9proZ2M1vNSjmI7qwSwij3XYSwc?= =?iso-8859-2?q?Y92FXqJdNvoWoEJN+1fiqnPSNUA1V3IsuDMUF24DBlKCtojGDvtgRjiSjZLM?= =?iso-8859-2?q?=3D?= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ecce9f6-59c0-4f7e-60fa-08db5fe07609 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 01:03:06.1578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OdhnIRxoJ+CxIqfDuAsZ3oIQWf9Z3rWPWnaKWUAHmpOdcU3YVWoMIigo1nAPslzLtwAGs60TCjNnmj7bFpfpGSovEVZJIegT19N1wf2IH71DUwbCp53HfPyatZ21wShu X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB8658 Message-ID-Hash: 6VKXX5YLGSNZP5JJTA4SQF5JIG4Z56UC X-Message-ID-Hash: 6VKXX5YLGSNZP5JJTA4SQF5JIG4Z56UC X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: soc_get_playback_capture() (A) checks dai_link status, and indicate error if it was not matching (B). (A) static int soc_get_playback_capture(...) { ... ^ if (dai_link->dynamic && dai_link->num_cpus > 1) { | dev_err(rtd->dev, (B) "DPCM doesn't support Multi CPU for Front-Ends yet\n"); | return -EINVAL; v } ... } We can use 100 char for 1 line today. This patch cleanup error code line. Signed-off-by: Kuninori Morimoto Reviewed-by: Amadeusz Sławiński --- sound/soc/soc-pcm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index db3fbe1af2ce..47da3be0ff46 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -2736,8 +2736,7 @@ static int soc_get_playback_capture(struct snd_soc_pcm_runtime *rtd, int i; if (dai_link->dynamic && dai_link->num_cpus > 1) { - dev_err(rtd->dev, - "DPCM doesn't support Multi CPU for Front-Ends yet\n"); + dev_err(rtd->dev, "DPCM doesn't support Multi CPU for Front-Ends yet\n"); return -EINVAL; }