ASoC: soc-core: add comment to jack at soc_remove_component()

Commit Message

Kuninori Morimoto Aug. 30, 2019, 12:30 a.m. UTC

From: Kuninori Morimoto <[e-mail]>

Basically, driver which setups snd_soc_component_set_jack() need
to release it by themselves. But, as framework level robustness,
soc_remove_component() also releases it.

To avoid code reader confuse, this patch makes it clarify.

This patch makes it clarify.

Signed-off-by: Kuninori Morimoto <[e-mail]>
---
 sound/soc/soc-core.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Mark Brown Sept. 3, 2019, 5:51 p.m. UTC | #1

On Fri, Aug 30, 2019 at 09:30:04AM +0900, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <[e-mail]>
> 
> Basically, driver which setups snd_soc_component_set_jack() need
> to release it by themselves. But, as framework level robustness,
> soc_remove_component() also releases it.
> 
> To avoid code reader confuse, this patch makes it clarify.
> 
> This patch makes it clarify.

This doesn't apply against current code, please check and resend.

Patch

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 659b90a..60f7e8b 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1171,7 +1171,9 @@  static void soc_remove_component(struct snd_soc_component *component)
 	if (component->probed)
 		snd_soc_component_remove(component);
 
+	/* For framework level robustness */
 	snd_soc_component_set_jack(component, NULL, NULL);
+
 	list_del(&component->card_list);
 	snd_soc_dapm_free(snd_soc_component_get_dapm(component));
 	soc_cleanup_component_debugfs(component);