| Message ID | 87sinbdk44.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 11, 2014 at 05:53:02PM -0700, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Current vendor-prefixes.txt already has > "ak" prefix for Asahi Kasei Corp by > ae8c4209af2cec065fef15d200a42a04130799f7 > (of: Add vendor prefix for Asahi Kasei Corp.) > > It went through the appropriate review process, > and is already in use. > But, almost all Asahi Kasei chip driver is > using "asahi-kasei" prefix today. > > Due to ABIness, this patch adds > "asahi-kasei" to vendor-prefixes.txt. > checkpatch.pl will report WARNING without this patch. > (DT compatible string vendor "asahi-kasei" appears un-documented) > > OTOH, Asahi Kasei is usually referred as "AKM", > but this patch doesn't care about it. > Because no DT is using it today. > > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>, > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Simon Horman <horms+renesas@verge.net.au> > --- > .../devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index abc3080..7e4bb83 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -17,6 +17,7 @@ amstaos AMS-Taos Inc. > apm Applied Micro Circuits Corporation (APM) > arm ARM Ltd. > armadeus ARMadeus Systems SARL > +asahi-kasei Asahi Kasei Corp. > atmel Atmel Corporation > auo AU Optronics Corporation > avago Avago Technologies > -- > 1.7.9.5 >
On 06/11/2014 06:53 PM, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Current vendor-prefixes.txt already has > "ak" prefix for Asahi Kasei Corp by > ae8c4209af2cec065fef15d200a42a04130799f7 > (of: Add vendor prefix for Asahi Kasei Corp.) > > It went through the appropriate review process, > and is already in use. > But, almost all Asahi Kasei chip driver is > using "asahi-kasei" prefix today. I'm fine with this patch, but just wanted to comment on this part of the commit description: What is in the drivers isn't relevant; that's not what drives the ABI. The issue is that some *DTs* use ak and some use asahi-kasei, so both those need to be supported. That said, we should document which one of the two prefixes is preferred, and use this for any new AK binding. It would also be nice to ensure the preferred prefix is in all drivers' of_match_tables, and remove the deprecated prefix from all drivers' of_match_tables *except* where there's already a DT file that references the deprecated vendor prefix.
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index abc3080..7e4bb83 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -17,6 +17,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies