From patchwork Fri May 23 02:05:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 4227751 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C650EBF90B for ; Fri, 23 May 2014 02:06:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0B4A320395 for ; Fri, 23 May 2014 02:06:03 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id CD78E20386 for ; Fri, 23 May 2014 02:06:01 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id B786B26565C; Fri, 23 May 2014 04:06:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id B116526563E; Fri, 23 May 2014 04:05:49 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B8E5826563E; Fri, 23 May 2014 04:05:48 +0200 (CEST) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by alsa0.perex.cz (Postfix) with ESMTP id 70BCB265634 for ; Fri, 23 May 2014 04:05:40 +0200 (CEST) Received: by mail-vc0-f169.google.com with SMTP id ij19so5464321vcb.14 for ; Thu, 22 May 2014 19:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=gUsHmaRBchIpJ8DPytpJWYq4inalTIFIjKdahEh7FJQ=; b=TUkXPxFMbNNi+4r3JYbqtg+Nuihfz9h7ii/Rx2ZeMWr1V3ze8xa3ktguiFrFwISYRg EPizKdQelmE/dZus0X2+0sI5pkelBhJLCgZcrmBIYOqDjMN6JiXVJtNW61nCnFxmRBc2 qu6Mr3OOfJUvd+2sr6FdEiCoH88HBsKJ8sg5LD9h63aFzqjd16vBNS5lmrrMIyIe7j89 0OIjrcukUQztjqbVe8R0XGlvtTuQ5/2o4wGfhEoDc1KVYAFj4KaXWdkZP2nmYinJzlgG pBEfWo+szet85FQDPgBPyq1XLfXKj8dobtnQNp/8KzMTHBWmHu8SvWHsB7L60cC2iS48 1f1g== MIME-Version: 1.0 X-Received: by 10.52.27.209 with SMTP id v17mr1124798vdg.23.1400810739214; Thu, 22 May 2014 19:05:39 -0700 (PDT) Received: by 10.58.19.102 with HTTP; Thu, 22 May 2014 19:05:39 -0700 (PDT) In-Reply-To: References: <20140522145650.GD32184@dragon> <20140522174818.GN12304@sirena.org.uk> Date: Thu, 22 May 2014 23:05:39 -0300 Message-ID: From: Fabio Estevam To: Mark Brown Cc: Fabio Estevam , "alsa-devel@alsa-project.org" , "linux-arm-kernel@lists.infradead.org" , Shawn Guo Subject: Re: [alsa-devel] The resume of sgtl5000 causes kernel Oops X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, May 22, 2014 at 6:33 PM, Fabio Estevam wrote: > sgtl5000 1-000a: Failed to restore cache: -5 > sgtl5000 1-000a: Failed to restore cache: -5 > sgtl5000 1-000a: ASoC: Failed to turn on bias: -5 > sgtl5000 1-000a: Failed to restore cache: -5 > sgtl5000 1-000a: ASoC: Failed to turn on bias: -5 > sgtl5000 1-000a: Failed to restore cache: -5 > sgtl5000 1-000a: ASoC: Failed to turn on bias: -5 These errors are gone if on top of the previous change I add: --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -36,29 +36,55 @@ /* default value of sgtl5000 registers */ static const struct reg_default sgtl5000_reg_defaults[] = { - { SGTL5000_CHIP_CLK_CTRL, 0x0008 }, - { SGTL5000_CHIP_I2S_CTRL, 0x0010 }, - { SGTL5000_CHIP_SSS_CTRL, 0x0010 }, + { SGTL5000_CHIP_DIG_POWER, 0x0000 }, + { SGTL5000_CHIP_CLK_CTRL, 0x0008 }, + { SGTL5000_CHIP_I2S_CTRL, 0x0010 }, + { SGTL5000_CHIP_SSS_CTRL, 0x0010 }, + { SGTL5000_CHIP_ADCDAC_CTRL, 0x020c }, { SGTL5000_CHIP_DAC_VOL, 0x3c3c }, { SGTL5000_CHIP_PAD_STRENGTH, 0x015f }, - { SGTL5000_CHIP_ANA_HP_CTRL, 0x1818 }, + { SGTL5000_CHIP_ANA_ADC_CTRL, 0x0000 }, + { SGTL5000_CHIP_ANA_HP_CTRL, 0x1818 }, { SGTL5000_CHIP_ANA_CTRL, 0x0111 }, + { SGTL5000_CHIP_LINREG_CTRL, 0x0000 }, + { SGTL5000_CHIP_REF_CTRL, 0x0000 }, + { SGTL5000_CHIP_MIC_CTRL, 0x0000 }, + { SGTL5000_CHIP_LINE_OUT_CTRL, 0x0000 }, { SGTL5000_CHIP_LINE_OUT_VOL, 0x0404 }, { SGTL5000_CHIP_ANA_POWER, 0x7060 }, { SGTL5000_CHIP_PLL_CTRL, 0x5000 }, + { SGTL5000_CHIP_CLK_TOP_CTRL, 0x0000 }, + { SGTL5000_CHIP_ANA_STATUS, 0x0000 }, + { SGTL5000_CHIP_SHORT_CTRL, 0x0000 }, + { SGTL5000_CHIP_ANA_TEST2, 0x0000 }, + { SGTL5000_DAP_CTRL, 0x0000 }, + { SGTL5000_DAP_PEQ, 0x0000 }, { SGTL5000_DAP_BASS_ENHANCE, 0x0040 }, { SGTL5000_DAP_BASS_ENHANCE_CTRL, 0x051f }, + { SGTL5000_DAP_AUDIO_EQ, 0x0000 }, { SGTL5000_DAP_SURROUND, 0x0040 }, + { SGTL5000_DAP_FLT_COEF_ACCESS, 0x0000 }, + { SGTL5000_DAP_COEF_WR_B0_MSB, 0x0000 }, + { SGTL5000_DAP_COEF_WR_B0_LSB, 0x0000 }, { SGTL5000_DAP_EQ_BASS_BAND0, 0x002f }, { SGTL5000_DAP_EQ_BASS_BAND1, 0x002f }, { SGTL5000_DAP_EQ_BASS_BAND2, 0x002f }, { SGTL5000_DAP_EQ_BASS_BAND3, 0x002f }, - { SGTL5000_DAP_EQ_BASS_BAND4, 0x002f }, + { SGTL5000_DAP_EQ_BASS_BAND4, 0x002f }, { SGTL5000_DAP_MAIN_CHAN, 0x8000 }, + { SGTL5000_DAP_MIX_CHAN, 0x0000 }, { SGTL5000_DAP_AVC_CTRL, 0x0510 }, { SGTL5000_DAP_AVC_THRESHOLD, 0x1473 }, { SGTL5000_DAP_AVC_ATTACK, 0x0028 }, { SGTL5000_DAP_AVC_DECAY, 0x0050 }, + { SGTL5000_DAP_COEF_WR_B1_MSB, 0x0000 }, + { SGTL5000_DAP_COEF_WR_B1_LSB, 0x0000 }, + { SGTL5000_DAP_COEF_WR_B2_MSB, 0x0000 }, + { SGTL5000_DAP_COEF_WR_B2_LSB, 0x0000 }, + { SGTL5000_DAP_COEF_WR_A1_MSB, 0x0000 }, + { SGTL5000_DAP_COEF_WR_A1_LSB, 0x0000 }, + { SGTL5000_DAP_COEF_WR_A2_MSB, 0x0000 }, + { SGTL5000_DAP_COEF_WR_A2_LSB, 0x0000 }, }; ,but now I am not able to play audio again after suspend/resume.