diff mbox series

ASoC: fsl: imx-hdmi: Fix an uninitialized return in probe

Message ID X9NGQaF4pmK8oUAF@mwanda (mailing list archive)
State Accepted
Commit acd894aee3149c15847bc4f0690fccba59ced5e7
Headers show
Series ASoC: fsl: imx-hdmi: Fix an uninitialized return in probe | expand

Commit Message

Dan Carpenter Dec. 11, 2020, 10:13 a.m. UTC 
The "ret" variable should be set to a negative error code but
currently it returns uninitialized stack data.

Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 sound/soc/fsl/imx-hdmi.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c
index 2c2a76a71940..ede4a9ad1054 100644
--- a/sound/soc/fsl/imx-hdmi.c
+++ b/sound/soc/fsl/imx-hdmi.c
@@ -164,6 +164,7 @@  static int imx_hdmi_probe(struct platform_device *pdev)
 
 	if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) {
 		dev_err(&pdev->dev, "Invalid HDMI DAI link\n");
+		ret = -EINVAL;
 		goto fail;
 	}