| Message ID | YyGbWM5wEoFMbW2v@piranha (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5570 laptop | expand |
On Wed, 14 Sep 2022 11:14:00 +0200, acheronfail wrote: > > The Dell Precision 5570 uses the same 4-speakers-on-ALC289 just like the > previous Precision 5560. I replicated that patch onto this one, and can > confirm that the audio is much better (the woofers are now working); > I've tested it on my Dell Precision 5570. > > Signed-off-by: Callum Osmotherly <callum.osmotherly@gmail.com> > > --- > Thanks to Takashi for helping me out with the right formatting! Glad to hear. One more thing I forgot to mention, though: if you keep the name in From field different from Signed-off-by line, you can embed the From tag into the patch itself, too, so that it's applied consistently. That is, a patch text will be: From: Callum Osmotherly <callum.osmotherly@gmail.com> The Dell Precision 5570 uses the same 4-speakers-on-ALC289 just like the previous Precision 5560. I replicated that patch onto this one, and can confirm that the audio is much better (the woofers are now working); I've tested it on my Dell Precision 5570. Signed-off-by: Callum Osmotherly <callum.osmotherly@gmail.com> I already applied this patch with the correction in my side now, so it's just a hint for the next submission :) thanks, Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 799f6bf266dd..b0ad4856b877 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9130,6 +9130,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0a9d, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0a9e, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0b19, "Dell XPS 15 9520", ALC289_FIXUP_DUAL_SPK), + SND_PCI_QUIRK(0x1028, 0x0b1a, "Dell Precision 5570", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
The Dell Precision 5570 uses the same 4-speakers-on-ALC289 just like the previous Precision 5560. I replicated that patch onto this one, and can confirm that the audio is much better (the woofers are now working); I've tested it on my Dell Precision 5570. Signed-off-by: Callum Osmotherly <callum.osmotherly@gmail.com> --- Thanks to Takashi for helping me out with the right formatting! --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)