diff mbox series

[1/1] ALSA: remove ALC289_FIXUP_DUAL_SPK for Dell 5530

Message ID Yz0uyN1zwZhnyRD6@piranha (mailing list archive)
State Accepted
Commit 417b9c51f59734d852e47252476fadc293ad994a
Headers show
Series [1/1] ALSA: remove ALC289_FIXUP_DUAL_SPK for Dell 5530 | expand

Commit Message

Callum Osmotherly Oct. 5, 2022, 7:14 a.m. UTC 
From: Callum Osmotherly <callum.osmotherly@gmail.com>

After some feedback from users with Dell Precision 5530 machines, this
patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK.
While it improved the speaker output quality, it caused the headphone
jack to have an audible "pop" sound when power saving was toggled.

Signed-off-by: Callum Osmotherly <callum.osmotherly@gmail.com>

---
 sound/pci/hda/patch_realtek.c | 1 -
 1 file changed, 1 deletion(-)

--
2.37.3

Comments

Takashi Iwai Oct. 5, 2022, 12:54 p.m. UTC | #1 
On Wed, 05 Oct 2022 09:14:16 +0200,
Callum Osmotherly wrote:
> 
> From: Callum Osmotherly <callum.osmotherly@gmail.com>
> 
> After some feedback from users with Dell Precision 5530 machines, this
> patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK.
> While it improved the speaker output quality, it caused the headphone
> jack to have an audible "pop" sound when power saving was toggled.
> 
> Signed-off-by: Callum Osmotherly <callum.osmotherly@gmail.com>

Thanks, applied.


Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index d35934f..ab6d736 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8836,7 +8836,6 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB),
-	SND_PCI_QUIRK(0x1028, 0x087d, "Dell Precision 5530", ALC289_FIXUP_DUAL_SPK),
 	SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB),