| Message ID | a2e2ae888b3c2fbcaab3e4791ce98f877e3d38ff.1553017237.git.Adam.Thomson.Opensource@diasemi.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 41d176d3ec147f499614adc773080f244d47e3cd |
| Headers | show |
| Series | ASoC: da7219: Extend CCF support to allow WCLK/BCLK config | expand |
On Tue, Mar 19, 2019 at 05:49:30PM +0000, Adam Thomson wrote: > -- #clock-cells : Should be set to '<0>', only one clock source provided; > -- clock-output-names : Name given for DAI clocks output; > +- #clock-cells : Should be set to '<1>', two clock sources provided; > +- clock-output-names : Names given for DAI clock outputs (WCLK & BCLK); This might need some handling later on as it's a binding change, however I can't see any current users so hopefully nobody will notice.
On 21 March 2019 12:22, Mark Brown wrote: > On Tue, Mar 19, 2019 at 05:49:30PM +0000, Adam Thomson wrote: > > > -- #clock-cells : Should be set to '<0>', only one clock source > > provided; > > -- clock-output-names : Name given for DAI clocks output; > > +- #clock-cells : Should be set to '<1>', two clock sources provided; > > +- clock-output-names : Names given for DAI clock outputs (WCLK & > > +BCLK); > > This might need some handling later on as it's a binding change, however I can't > see any current users so hopefully nobody will notice. No I do not believe there are users of this, other than the AMD board which doesn't use these bindings. Actually given they're the same bindings, albeit with a different number of cells, I've tested the code with just 1 cell and 1 clock in the DTS and this still works as before so the driver should be backwards compatible.
diff --git a/Documentation/devicetree/bindings/sound/da7219.txt b/Documentation/devicetree/bindings/sound/da7219.txt index e9d0bae..add1caf 100644 --- a/Documentation/devicetree/bindings/sound/da7219.txt +++ b/Documentation/devicetree/bindings/sound/da7219.txt @@ -23,8 +23,8 @@ Optional properties: interrupt is to be used to wake system, otherwise "irq" should be used. - wakeup-source: Flag to indicate this device can wake system (suspend/resume). -- #clock-cells : Should be set to '<0>', only one clock source provided; -- clock-output-names : Name given for DAI clocks output; +- #clock-cells : Should be set to '<1>', two clock sources provided; +- clock-output-names : Names given for DAI clock outputs (WCLK & BCLK); - clocks : phandle and clock specifier for codec MCLK. - clock-names : Clock name string for 'clocks' attribute, should be "mclk". @@ -84,8 +84,8 @@ Example: VDDMIC-supply = <®_audio>; VDDIO-supply = <®_audio>; - #clock-cells = <0>; - clock-output-names = "dai-clks"; + #clock-cells = <1>; + clock-output-names = "dai-wclk", "dai-bclk"; clocks = <&clks 201>; clock-names = "mclk";
With the need to expose WCLK and BCLK as separate clocks, the 'clock-cells' and 'clock-output-names' descriptions need to be updated as now the codec is providing 2 clocks. The example is also updated accordingly. Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> --- Documentation/devicetree/bindings/sound/da7219.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)