| Message ID | ad408ff8dc4e5fae0884312cb0aa618664e546e5.1583896348.git.joe@perches.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | treewide: use fallthrough; | expand |
Hi Joe, Joe Perches <joe@perches.com> wrote on Tue, 10 Mar 2020 21:51:27 -0700: > Convert the various uses of fallthrough comments to fallthrough; > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- > drivers/mmc/host/jz4740_mmc.c | 6 ++---- > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- > sound/soc/codecs/jz4770.c | 2 +- > 6 files changed, 9 insertions(+), 11 deletions(-) I like very much the new way to advertise for fallthrough statements, but I am not willing to take any patch converting a single driver anymore. I had too many from Gustavo when these comments had to be inserted. I would really prefer a MTD-wide or a NAND-wide or at least a raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/). Hope you'll understand! Thanks, Miquèl
On Wed, 11 Mar 2020 at 08:40, Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Hi Joe, > > Joe Perches <joe@perches.com> wrote on Tue, 10 Mar 2020 21:51:27 -0700: > > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > > > Signed-off-by: Joe Perches <joe@perches.com> > > --- > > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- > > drivers/mmc/host/jz4740_mmc.c | 6 ++---- > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- > > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- > > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- > > sound/soc/codecs/jz4770.c | 2 +- > > 6 files changed, 9 insertions(+), 11 deletions(-) > > I like very much the new way to advertise for fallthrough statements, > but I am not willing to take any patch converting a single driver > anymore. I had too many from Gustavo when these comments had to be > inserted. I would really prefer a MTD-wide or a NAND-wide or at least a > raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/). > > Hope you'll understand! I fully agree (for mmc). One patch please. Another option is to make a big fat tree wide patch and ask Linus if he want to pick up immediately after an rc1. That should cause less disturbance for everyone, no? Kind regards Uffe
Ulf Hansson <ulf.hansson@linaro.org> wrote on Wed, 11 Mar 2020 15:20:59 +0100: > On Wed, 11 Mar 2020 at 08:40, Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > > Hi Joe, > > > > Joe Perches <joe@perches.com> wrote on Tue, 10 Mar 2020 21:51:27 -0700: > > > > > Convert the various uses of fallthrough comments to fallthrough; > > > > > > Done via script > > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > > > > > Signed-off-by: Joe Perches <joe@perches.com> > > > --- > > > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- > > > drivers/mmc/host/jz4740_mmc.c | 6 ++---- > > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- > > > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- > > > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- > > > sound/soc/codecs/jz4770.c | 2 +- > > > 6 files changed, 9 insertions(+), 11 deletions(-) > > > > I like very much the new way to advertise for fallthrough statements, > > but I am not willing to take any patch converting a single driver > > anymore. I had too many from Gustavo when these comments had to be > > inserted. I would really prefer a MTD-wide or a NAND-wide or at least a > > raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/). > > > > Hope you'll understand! > > I fully agree (for mmc). One patch please. > > Another option is to make a big fat tree wide patch and ask Linus if > he want to pick up immediately after an rc1. That should cause less > disturbance for everyone, no? Absolutely. Miquèl
On Wed, 2020-03-11 at 08:40 +0100, Miquel Raynal wrote: > Hi Joe, > > Joe Perches <joe@perches.com> wrote on Tue, 10 Mar 2020 21:51:27 -0700: > > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > > > Signed-off-by: Joe Perches <joe@perches.com> > > --- > > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- > > drivers/mmc/host/jz4740_mmc.c | 6 ++---- > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- > > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- > > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- > > sound/soc/codecs/jz4770.c | 2 +- > > 6 files changed, 9 insertions(+), 11 deletions(-) > > I like very much the new way to advertise for fallthrough statements, > but I am not willing to take any patch converting a single driver > anymore. I had too many from Gustavo when these comments had to be > inserted. I would really prefer a MTD-wide or a NAND-wide or at least a > raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/). I understand completely. This set was done to generate patches by nominally maintained subsystems. If you want something else: The easiest thing for you to do would be to run the cvt_fallthrough.pl script yourself. $ cvt_fallthrough.pl drivers/mtd/nand/raw/ That would produce: $ git diff --shortstat drivers/mtd/nand/raw 9 files changed, 18 insertions(+), 24 deletions(-) or $ cvt_fallthrough.pl drivers/mtd/ which would produce: $ git diff --shortstat drivers/mtd/ 22 files changed, 45 insertions(+), 60 deletions(-) cheers, Joe
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c index 9dfe7c..8eefe7 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c @@ -305,7 +305,7 @@ static void ingenic_drm_crtc_update_ctrl(struct ingenic_drm *priv, switch (finfo->format) { case DRM_FORMAT_XRGB1555: ctrl |= JZ_LCD_CTRL_RGB555; - /* fall-through */ + fallthrough; case DRM_FORMAT_RGB565: ctrl |= JZ_LCD_CTRL_BPP_15_16; break; diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c index fbae87..9026af6 100644 --- a/drivers/mmc/host/jz4740_mmc.c +++ b/drivers/mmc/host/jz4740_mmc.c @@ -737,8 +737,7 @@ static irqreturn_t jz_mmc_irq_worker(int irq, void *devid) break; jz_mmc_prepare_data_transfer(host); - /* fall through */ - + fallthrough; case JZ4740_MMC_STATE_TRANSFER_DATA: if (host->use_dma) { /* Use DMA if enabled. @@ -772,8 +771,7 @@ static irqreturn_t jz_mmc_irq_worker(int irq, void *devid) break; } jz4740_mmc_write_irq_reg(host, JZ_MMC_IRQ_DATA_TRAN_DONE); - /* fall through */ - + fallthrough; case JZ4740_MMC_STATE_SEND_STOP: if (!req->stop) break; diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c index 49afeb..935c49 100644 --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c @@ -253,7 +253,7 @@ static int ingenic_nand_attach_chip(struct nand_chip *chip) chip->ecc.hwctl = ingenic_nand_ecc_hwctl; chip->ecc.calculate = ingenic_nand_ecc_calculate; chip->ecc.correct = ingenic_nand_ecc_correct; - /* fall through */ + fallthrough; case NAND_ECC_SOFT: dev_info(nfc->dev, "using %s (strength %d, size %d, bytes %d)\n", (nfc->ecc) ? "hardware ECC" : "software ECC", diff --git a/drivers/mtd/nand/raw/ingenic/jz4725b_bch.c b/drivers/mtd/nand/raw/ingenic/jz4725b_bch.c index 6c852ea..2d0e0a 100644 --- a/drivers/mtd/nand/raw/ingenic/jz4725b_bch.c +++ b/drivers/mtd/nand/raw/ingenic/jz4725b_bch.c @@ -145,10 +145,10 @@ static void jz4725b_bch_read_parity(struct ingenic_ecc *bch, u8 *buf, switch (size8) { case 3: dest8[2] = (val >> 16) & 0xff; - /* fall-through */ + fallthrough; case 2: dest8[1] = (val >> 8) & 0xff; - /* fall-through */ + fallthrough; case 1: dest8[0] = val & 0xff; break; diff --git a/drivers/mtd/nand/raw/ingenic/jz4780_bch.c b/drivers/mtd/nand/raw/ingenic/jz4780_bch.c index 079266a..d67dbf 100644 --- a/drivers/mtd/nand/raw/ingenic/jz4780_bch.c +++ b/drivers/mtd/nand/raw/ingenic/jz4780_bch.c @@ -123,10 +123,10 @@ static void jz4780_bch_read_parity(struct ingenic_ecc *bch, void *buf, switch (size8) { case 3: dest8[2] = (val >> 16) & 0xff; - /* fall through */ + fallthrough; case 2: dest8[1] = (val >> 8) & 0xff; - /* fall through */ + fallthrough; case 1: dest8[0] = val & 0xff; break; diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c index e7cf2c..6e2a91 100644 --- a/sound/soc/codecs/jz4770.c +++ b/sound/soc/codecs/jz4770.c @@ -202,7 +202,7 @@ static int jz4770_codec_set_bias_level(struct snd_soc_component *codec, REG_CR_VIC_SB_SLEEP, REG_CR_VIC_SB_SLEEP); regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_VIC, REG_CR_VIC_SB, REG_CR_VIC_SB); - /* fall-through */ + fallthrough; default: break; }
Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches <joe@perches.com> --- drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- drivers/mmc/host/jz4740_mmc.c | 6 ++---- drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- sound/soc/codecs/jz4770.c | 2 +- 6 files changed, 9 insertions(+), 11 deletions(-)