From patchwork Mon Nov 2 06:55:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 7534201 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1CA17BEEA4 for ; Mon, 2 Nov 2015 06:55:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4E78F205F5 for ; Mon, 2 Nov 2015 06:55:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 53CED205EF for ; Mon, 2 Nov 2015 06:55:27 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 35BF3260672; Mon, 2 Nov 2015 07:55:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 31FEF26065A; Mon, 2 Nov 2015 07:55:14 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 1E4CF26065E; Mon, 2 Nov 2015 07:55:12 +0100 (CET) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by alsa0.perex.cz (Postfix) with ESMTP id 0D6C8260647 for ; Mon, 2 Nov 2015 07:55:04 +0100 (CET) X-IronPort-AV: E=Sophos;i="5.20,233,1444687200"; d="scan'208";a="185520505" Received: from 198.67.28.109.rev.sfr.net (HELO hadrien) ([109.28.67.198]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 02 Nov 2015 07:55:03 +0100 Date: Mon, 2 Nov 2015 07:55:03 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Takashi Sakamoto Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, Takashi Iwai , Clemens Ladisch , linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: [alsa-devel] [PATCH] ALSA: firewire-lib: fix compare_const_fl.cocci warnings X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Move constant to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Takashi Sakamoto Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- Depends on personal taste, but the modified version does look a little nicer to me, since one can better see the relationship between the fdf and sfc fields. amdtp-am824.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/firewire/amdtp-am824.c +++ b/sound/firewire/amdtp-am824.c @@ -36,7 +36,7 @@ int amdtp_am824_set_parameters(struct am if (err < 0) return err; - s->fdf = AMDTP_FDF_AM824 | s->sfc; + s->fdf = s->sfc | AMDTP_FDF_AM824; /* * In IEC 61883-6, one data block represents one event. In ALSA, one