diff mbox series

ASoC: soc-core: fix ifnullfree.cocci warnings

Message ID alpine.DEB.2.21.1905301904530.2500@hadrien (mailing list archive)
State New, archived
Headers show
Series ASoC: soc-core: fix ifnullfree.cocci warnings | expand

Commit Message

Julia Lawall May 30, 2019, 11:06 p.m. UTC 
From: kbuild test robot <lkp@intel.com>

sound/soc/soc-core.c:391:2-7: WARNING: NULL check before some freeing functions is not needed.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: 8e144273005d ("ASoC: soc-core: merge soc_new_pcm_runtime() and soc_rtd_init()")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

tree:   https://github.com/morimoto/linux fw-cleanup-2019-05-30-v3
head:   7f2c61a9097fcf25dac44865db31e7eab5c8fc9d
commit: 8e144273005d3caf8b9978e407e3d00b6180dd49 [96/103] ASoC: soc-core: merge soc_new_pcm_runtime() and soc_rtd_init()
:::::: branch date: 12 hours ago
:::::: commit date: 12 hours ago

Please take the patch only if it's a positive warning. Thanks!

 soc-core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Mark Brown June 3, 2019, 5:58 p.m. UTC | #1 
On Thu, May 30, 2019 at 07:06:11PM -0400, Julia Lawall wrote:
> From: kbuild test robot <lkp@intel.com>
> 
> sound/soc/soc-core.c:391:2-7: WARNING: NULL check before some freeing functions is not needed.
> 
>  NULL check before some freeing functions is not needed.

This doesn't apply against current code, please check and resend.
diff mbox series

Patch

--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -387,8 +387,7 @@  static void soc_free_pcm_runtime(struct

 	snd_soc_rtdcom_del_all(rtd);

-	if (rtd->codec_dais)
-		kfree(rtd->codec_dais);
+	kfree(rtd->codec_dais);

 	list_del(&rtd->list);
 	kfree(rtd);